You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by hl...@apache.org on 2013/06/01 01:06:51 UTC

git commit: TAP5-2122: visible() on empty
is false

Updated Branches:
  refs/heads/master 2f245e694 -> 47c83bb83


TAP5-2122: visible() on empty <div> is false


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/47c83bb8
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/47c83bb8
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/47c83bb8

Branch: refs/heads/master
Commit: 47c83bb8374bc12e1c915e5b62c34b8c57ba5a53
Parents: 2f245e6
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Fri May 31 16:06:41 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Fri May 31 16:06:41 2013 -0700

----------------------------------------------------------------------
 .../org/apache/tapestry5/t5-core-dom-jquery.coffee |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/47c83bb8/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-jquery.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-jquery.coffee b/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-jquery.coffee
index f6ed977..5b39305 100644
--- a/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-jquery.coffee
+++ b/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-jquery.coffee
@@ -279,7 +279,7 @@ define ["_", "./utils", "jquery"], (_, utils, $) ->
     # Returns true if this element is visible, false otherwise. This does not check to see if all containers of the
     # element are visible.
     visible: ->
-      @$.is(":visible")
+      @$.css("display") isnt "hidden"
 
     # Returns true if this element is visible, and all parent elements are also visible, up to the document body.
     #
@@ -331,7 +331,7 @@ define ["_", "./utils", "jquery"], (_, utils, $) ->
         @$.val newValue
 
       return current
-      
+
     # Returns true if a checkbox is checked
     checked: ->
       return @$.is(':checked')