You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/07/13 06:27:06 UTC

[GitHub] [shardingsphere] FlyingZC opened a new issue, #27050: Support parsing Oracle CREATE MATERIALIZED sql

FlyingZC opened a new issue, #27050:
URL: https://github.com/apache/shardingsphere/issues/27050

   # Background
   Hi community,
   This issue is for #26878.
   
   ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for Oracle SQL parsing in ShardingSphere.
   
   More details:
   https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
   
   # Task
   This issue is to support more oracle sql parse, as follows:
   ```sql
   CREATE MATERIALIZED VIEW product_sales_mv
   BUILD IMMEDIATE
   REFRESH FORCE
   ENABLE QUERY REWRITE AS
   SELECT p.prod_name, SUM(s.amount_sold) AS dollar_sales
   FROM products p, sales s
   WHERE p.prod_id = s.prod_id
   GROUP BY prod_name
   HAVING SUM(s.amount_sold) BETWEEN 5000 AND 50000;
   ```
   
   ```sql
   CREATE OPERATOR Contains
   BINDING 
   (VARCHAR2, VARCHAR2) RETURN NUMBER 
   USING text.contains, 
   (spatial.geo, spatial.geo) RETURN NUMBER 
   USING spatial.contains;
   ```
   
   ```sql
   CREATE MATERIALIZED VIEW sales_pcat_cal_day_mv 
   ENABLE QUERY REWRITE AS
   SELECT p.prod_category, t.day_in_year, SUM(s.amount_sold) AS sum_amount_sold
   FROM time_view t, sales s, products p 
   WHERE t.time_id = s.time_id AND p.prod_id = s.prod_id
   GROUP BY p.prod_category, t.day_in_year;
   ```
   
   ```sql
   CREATE MATERIALIZED VIEW sales_per_country_mv
   BUILD IMMEDIATE
   REFRESH FORCE ON DEMAND
   ENABLE QUERY REWRITE AS
   SELECT s.calendar_year AS calendar_year, s.country_name AS country_name,
    p.prod_name AS prod_name, SUM(s.amount_sold) AS sum_sales, COUNT(*) AS cnt
   FROM sales_par_list s, products p
   WHERE s.prod_id = p.prod_id AND s.calendar_year <= 2000
   GROUP BY s.calendar_year, s.country_name, prod_name;
   ```
   
   ```sql
   CREATE MATERIALIZED VIEW sales_shipping_lag_mv
   ENABLE QUERY REWRITE AS
   SELECT t1.fiscal_week_number, s.prod_id,
            t2.fiscal_week_number - t1.fiscal_week_number AS lag
   FROM times t1, sales s, times t2 
   WHERE t1.time_id = s.time_id AND t2.time_id = s.time_id_ship;
   ```
   
   # Process
   1. First confirm that this is a correct oracle sql syntax, if not please ignore;
   2. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
   3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
   4. Run mvn install the current_file_module;
   5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
   6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML;
   7. Run SQLParserParameterizedTest to make sure no exceptions.
   
   # Relevant Skills
   1. Master JAVA language
   2. Have a basic understanding of Antlr `g4` file
   3. Be familiar with Oracle SQLs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle CREATE MATERIALIZED sql [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on issue #27050:
URL: https://github.com/apache/shardingsphere/issues/27050#issuecomment-5329009707

   Hi @FlyingZC, thanks for reporting this. This has already been implemented and can be closed as done.
   
   Oracle `CREATE MATERIALIZED VIEW` / `CREATE MATERIALIZED VIEW LOG` parsing was added in #27994, including the ANTLR grammar rules, the `OracleDDLStatementVisitor` support, the `OracleCreateMaterializedViewStatement` / `OracleCreateMaterializedViewLogStatement` statement classes, and parser test cases covering the `BUILD IMMEDIATE`, `REFRESH FORCE`, `ON DEMAND` and `ENABLE QUERY REWRITE` variants listed in this issue. The `CREATE OPERATOR` statement from the task list is also supported and covered by test cases. The fix shipped in release 5.4.1, so any 5.4.1+ version includes it.
   
   I'll close this issue as completed. Feel free to reopen it if you find a `CREATE MATERIALIZED` statement that still fails to parse on a recent version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle CREATE MATERIALIZED sql [shardingsphere]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27050:
URL: https://github.com/apache/shardingsphere/issues/27050#issuecomment-1785954436

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle CREATE MATERIALIZED sql [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed issue #27050: Support parsing Oracle CREATE MATERIALIZED sql
URL: https://github.com/apache/shardingsphere/issues/27050


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] commented on issue #27050: Support parsing Oracle CREATE MATERIALIZED sql

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27050:
URL: https://github.com/apache/shardingsphere/issues/27050#issuecomment-1676080919

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org