You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Jefffrey (via GitHub)" <gi...@apache.org> on 2024/02/02 23:01:33 UTC

[I] ci: run cargo audit [arrow-datafusion]

Jefffrey opened a new issue, #9116:
URL: https://github.com/apache/arrow-datafusion/issues/9116

   ### Is your feature request related to a problem or challenge?
   
   Run cargo audit as part of CI
   
   ### Describe the solution you'd like
   
   See arrow-rs: https://github.com/apache/arrow-rs/pull/5160
   
   ### Describe alternatives you've considered
   
   Don't do this
   
   ### Additional context
   
   Looks like this was attempted before: https://github.com/apache/arrow-datafusion/pull/599


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ci: run cargo audit [arrow-datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on issue #9116:
URL: https://github.com/apache/arrow-datafusion/issues/9116#issuecomment-1933686949

   Ah that's great then :+1: 
   
   Feel free to submit a PR with this added :eyes: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ci: run cargo audit [arrow-datafusion]

Posted by "ongchi (via GitHub)" <gi...@apache.org>.
ongchi commented on issue #9116:
URL: https://github.com/apache/arrow-datafusion/issues/9116#issuecomment-1931506911

   Hello @Jefffrey,
   I tried that action and it seems to works well.
   Here is the [log](https://github.com/ongchi/arrow-datafusion/actions/runs/7811652430/job/21307138257).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ci: run cargo audit [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #9116:
URL: https://github.com/apache/arrow-datafusion/issues/9116#issuecomment-1934038196

   > DataFusion probably moves fast enough that commits to main are enough for triggering audit check, but can explore making it scheduled again
   
   
   I agree triggering on commits to main would be good enough. Thank you @ongchi and @Jefffrey 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ci: run cargo audit [arrow-datafusion]

Posted by "ongchi (via GitHub)" <gi...@apache.org>.
ongchi commented on issue #9116:
URL: https://github.com/apache/arrow-datafusion/issues/9116#issuecomment-1929312562

   I noticed there is a [fork](https://github.com/rustsec/audit-check) of original audit-check action. I think this could be trusted since it is run by the Rust Secure Code WG.
   It would save much time and bandwidth on compilation and installation of cargo-audit in CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ci: run cargo audit [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #9116: ci: run cargo audit
URL: https://github.com/apache/arrow-datafusion/issues/9116


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ci: run cargo audit [arrow-datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on issue #9116:
URL: https://github.com/apache/arrow-datafusion/issues/9116#issuecomment-1924881219

   Marking as good first issue as there is the arrow-rs to base off from, and is self contained to only CI for this repo


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ci: run cargo audit [arrow-datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on issue #9116:
URL: https://github.com/apache/arrow-datafusion/issues/9116#issuecomment-1930747411

   > I noticed there is a [fork](https://github.com/rustsec/audit-check) of original audit-check action. I think this could be trusted since it is run by the Rust Secure Code WG. It would save much time and bandwidth on compilation and installation of cargo-audit in CI.
   
   I think I tried that action before but was unable to get it to run in CI, see:
   
   https://github.com/apache/arrow-rs/pull/5160#discussion_r1415540561
   
   So I opted for just including the shell steps manually, but if there's another way to get around that above error and use that audit-check action then all for it :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org