You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/23 14:55:42 UTC

[GitHub] tillrohrmann commented on a change in pull request #7546: [FLINK-11390][tests] Port YARNSessionCapacitySchedulerITCase#testTaskManagerFailure to new code base

tillrohrmann commented on a change in pull request #7546: [FLINK-11390][tests] Port YARNSessionCapacitySchedulerITCase#testTaskManagerFailure to new code base
URL: https://github.com/apache/flink/pull/7546#discussion_r250227506
 
 

 ##########
 File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNHighAvailabilityITCase.java
 ##########
 @@ -124,24 +135,84 @@ public void testKillYarnSessionClusterEntrypoint() throws Exception {
 
 		final ApplicationId id = restClusterClient.getClusterId();
 
-		waitUntilJobIsRunning(restClusterClient, jobId, RETRY_TIMEOUT);
+		waitUntilJobIsRunning(restClusterClient, jobId);
 
 		killApplicationMaster(yarnClusterDescriptor.getYarnSessionClusterEntrypoint());
+		waitForApplicationAttempt(id, 2);
 
+		waitUntilJobIsRunning(restClusterClient, jobId);
+
+		killApplicationAndWait(id);
+	}
+
+	@Test
+	public void testJobRecoversAfterKillingTaskManager() throws Exception {
+		final RestClusterClient<ApplicationId> restClusterClient = deploySessionCluster(setupYarnClusterDescriptor());
+		final JobID jobId = submitJob(restClusterClient, createJobGraph());
+		final ApplicationId id = restClusterClient.getClusterId();
+		waitUntilJobIsRunning(restClusterClient, jobId);
+
+		stopTaskManagerContainer();
+		waitUntilJobIsRunning(restClusterClient, jobId);
 
 Review comment:
   Can it happen that the JobManager does not realize that a `TM` has died before we call `waitUntilJobIsRunning`? Is there an easy way to check whether we have restarted the job?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services