You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/04/03 12:28:03 UTC
Re: Review Request 58129: HDP 3.0 TP - add Pig client: configs,
metainfo, descriptors, service advisor and etc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58129/#review170864
-----------------------------------------------------------
Ship it!
This is very weird idea to me how we just duplicate the code. Instead of using the old one.
Now every dev has to test two versions of the code.
Anyway +1
- Andrew Onischuk
On March 31, 2017, 11:50 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58129/
> -----------------------------------------------------------
>
> (Updated March 31, 2017, 11:50 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-20652
> https://issues.apache.org/jira/browse/AMBARI-20652
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Pig client to HDP 3.0
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/configuration/pig-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/configuration/pig-log4j.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/configuration/pig-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/package/files/pigSmoke.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/package/scripts/params_linux.py PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/package/scripts/params_windows.py PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/package/scripts/pig.py PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/package/scripts/pig_client.py PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/service_advisor.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/3.0/services/PIG/metainfo.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58129/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 58129: HDP 3.0 TP - add Pig client: configs,
metainfo, descriptors, service advisor and etc
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On April 3, 2017, 12:28 p.m., Andrew Onischuk wrote:
> > This is very weird idea to me how we just duplicate the code. Instead of using the old one.
> > Now every dev has to test two versions of the code.
> >
> > Anyway +1
Andrew, we're expecting massive changes in HDP 3.0 for all of the components in terms of packaging, configs, scripts, so that is why we are flattening the inheritance model in order to start from scratch, and allow make it easier in the near future to delegate ownership of the services to the stack teams.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58129/#review170864
-----------------------------------------------------------
On March 31, 2017, 11:50 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58129/
> -----------------------------------------------------------
>
> (Updated March 31, 2017, 11:50 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-20652
> https://issues.apache.org/jira/browse/AMBARI-20652
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Pig client to HDP 3.0
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/configuration/pig-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/configuration/pig-log4j.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/configuration/pig-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/package/files/pigSmoke.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/package/scripts/params_linux.py PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/package/scripts/params_windows.py PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/package/scripts/pig.py PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/package/scripts/pig_client.py PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/PIG/0.16.1.3.0/service_advisor.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/3.0/services/PIG/metainfo.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58129/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>