[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2850: ARTEMIS-2504 implement retroactive addresses

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #2850: ARTEMIS-2504 implement retroactive addresses
URL: https://github.com/apache/activemq-artemis/pull/2850#discussion_r337012368
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java
 ##########
 @@ -759,6 +761,15 @@ public AddressSettings setDefaultRingSize(final long defaultRingSize) {
       return this;
    }
 
+   public long getRetroactiveMessageCount() {
+      return retroactiveMessageCount != null ? retroactiveMessageCount : ActiveMQDefaultConfiguration.DEFAULT_RETROACTIVE_MESSAGE_COUNT;
+   }
+
+   public AddressSettings setRetroactiveMessageCount(final long defaultRetroactiveMessageCount) {
+      this.retroactiveMessageCount = defaultRetroactiveMessageCount;
+      return this;
+   }
+
 
 Review comment:
   I have tried to add a comment on a line you didn't touch on github and I couldn't  figure out how to do it...
   
   
   It seems you missed implementing the merge method here,
   
   you also missed implementing the persistence of the new attribute here.
   
   
   So, I think you should add implementation on this new attribute, and you should probably also add tests on loading the new setting.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services