You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/04/25 19:15:03 UTC

[jira] [Commented] (PIG-1981) LoadPushDown.pushProjection should pass alias in addition to position

    [ https://issues.apache.org/jira/browse/PIG-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024856#comment-13024856 ] 

jiraposter@reviews.apache.org commented on PIG-1981:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/663/
-----------------------------------------------------------

Review request for pig.


Summary
-------

See PIG-1981


This addresses bug PIG-1981.
    https://issues.apache.org/jira/browse/PIG-1981


Diffs
-----

  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/rules/ColumnPruneVisitor.java 1095812 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPruneColumn.java 1095812 

Diff: https://reviews.apache.org/r/663/diff


Testing
-------

Test-patch:
PIG-1981-1.patch
     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.

Unit-test:
    all pass


Thanks,

Daniel



> LoadPushDown.pushProjection should pass alias in addition to position
> ---------------------------------------------------------------------
>
>                 Key: PIG-1981
>                 URL: https://issues.apache.org/jira/browse/PIG-1981
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.8.0, 0.9.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.9.0
>
>         Attachments: PIG-1981-1.patch
>
>
> Currently
> pushProjection(RequiredFieldList requiredFieldList)
> requiredFieldList only contains position. It is better that we also provide alias whenever available.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira