You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Benchao Li (Jira)" <ji...@apache.org> on 2020/05/13 14:47:00 UTC

[jira] [Commented] (FLINK-17668) Fix shortcomings in new data structures

    [ https://issues.apache.org/jira/browse/FLINK-17668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106365#comment-17106365 ] 

Benchao Li commented on FLINK-17668:
------------------------------------

[~twalthr] FYI, I've add equals method for GenericMapData/GenericArrayData in [https://github.com/apache/flink/pull/12133]

> Fix shortcomings in new data structures
> ---------------------------------------
>
>                 Key: FLINK-17668
>                 URL: https://issues.apache.org/jira/browse/FLINK-17668
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / Planner, Table SQL / Runtime
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>
> There are a couple of shortcomings in the new data structures:
> - The some data structures do not provide a {{hashCode/equals}} for testing. 
> - `RawValueData` cannot be created from bytes.
> - Accessing elements requires dealing with logical types during runtime.
> - Null checks are performed multiple times during runtime even for types that are declared as NOT NULL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)