You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/12/17 01:52:30 UTC
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1052: [CELEBORN-61][CELEBORN-62][FEATURE] Shuffle client support slow start, congestion avoidance and congestion control
waitinfuture commented on code in PR #1052:
URL: https://github.com/apache/incubator-celeborn/pull/1052#discussion_r1051286301
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -665,11 +668,27 @@ public void onSuccess(ByteBuffer response) {
this,
pushState,
StatusCode.HARD_SPLIT));
+ } else if (reason == StatusCode.PUSH_DATA_SUCCESS_MASTER_CONGESTED.getValue()) {
+ logger.debug(
+ "Push data split for map {} attempt {} batch {} return master congested.",
+ mapId,
+ attemptId,
+ nextBatchId);
+ congestionControl();
Review Comment:
I think we also need to call callback.success here
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -665,11 +668,27 @@ public void onSuccess(ByteBuffer response) {
this,
pushState,
StatusCode.HARD_SPLIT));
+ } else if (reason == StatusCode.PUSH_DATA_SUCCESS_MASTER_CONGESTED.getValue()) {
+ logger.debug(
+ "Push data split for map {} attempt {} batch {} return master congested.",
+ mapId,
+ attemptId,
+ nextBatchId);
+ congestionControl();
+ } else if (reason == StatusCode.PUSH_DATA_SUCCESS_SLAVE_CONGESTED.getValue()) {
+ logger.debug(
+ "Push data split for map {} attempt {} batch {} return slave congested.",
+ mapId,
+ attemptId,
+ nextBatchId);
+ congestionControl();
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org