[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5569: pty: Move the post process after reading the buffer

[GitBox <gi...@apache.org>]

acassis commented on a change in pull request #5569:
URL: https://github.com/apache/incubator-nuttx/pull/5569#discussion_r811905162



##########
File path: drivers/serial/pty.c
##########
@@ -452,17 +452,28 @@ static ssize_t pty_read(FAR struct file *filep, FAR char *buffer, size_t len)
   FAR struct pty_dev_s *dev;
   ssize_t ntotal;
 #ifdef CONFIG_SERIAL_TERMIOS
-  ssize_t nread;
-  size_t i;
+  ssize_t i;
+  ssize_t j;
   char ch;
-  int ret;
 #endif
 
   DEBUGASSERT(filep != NULL && filep->f_inode != NULL);
   inode = filep->f_inode;
   dev   = inode->i_private;
   DEBUGASSERT(dev != NULL);
 
+  /* NOTE: the source pipe will block if no data is available in
+   * the pipe.   Otherwise, it will return data from the pipe.  If

Review comment:
       Please remove the extra spaces after the ".", no need to justify the text




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org