You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "khanimteyaz (GitHub)" <gi...@apache.org> on 2019/01/15 07:45:14 UTC

[GitHub] [incubator-dubbo] khanimteyaz commented on pull request #3233: [Dubbo-3231]keep TagRouter consistent with 2.6.x

Is this 
```
if (CollectionUtils.isEmpty(result) && !isForceUseTag(invocation)) {
                result = filterInvoker(invokers, invoker -> StringUtils.isEmpty(invoker.getUrl().getParameter(Constants.TAG_KEY)));
            }
```
should not be irrespective of whether **tag** present or not? I was just referring to 2.6.x implementaion where it seems to me this logic is outside of whether tag is present or not.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3233 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org