You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2018/08/06 10:30:26 UTC
Review Request 68225: Added 25th and 75th percentiles to `Statistics`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68225/
-----------------------------------------------------------
Review request for mesos, Benno Evers and Benjamin Mahler.
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/statistics.hpp e9f1fc23bf83f92a2e7de94dba0df48272cc3394
3rdparty/libprocess/src/tests/statistics_tests.cpp a2a780bf9de018c823b68aa48977fd9fd1b8a064
Diff: https://reviews.apache.org/r/68225/diff/1/
Testing
-------
https://reviews.apache.org/r/68132/
Thanks,
Alexander Rukletsov
Re: Review Request 68225: Added 25th and 75th percentiles to
`Statistics`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Aug. 6, 2018, 5:57 p.m., Benjamin Mahler wrote:
> > 3rdparty/libprocess/include/process/statistics.hpp
> > Line 80 (original), 80-82 (patched)
> > <https://reviews.apache.org/r/68225/diff/1/?file=2068401#file2068401line80>
> >
> > Do you want a TODO to expose these in metrics snapshots? E.g.
> >
> > ```
> > T p25; // TODO(alexr): Expose this in metrics snapshots.
> > T p75; // TODO(alexr): Expose this in metrics snapshots.
> > ```
> >
> > Or just expose them in this patch?
Added a TODO in "libprocess/src/metrics/metrics.cpp".
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68225/#review206891
-----------------------------------------------------------
On Aug. 9, 2018, 2:21 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68225/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2018, 2:21 p.m.)
>
>
> Review request for mesos, Benno Evers and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/statistics.hpp e9f1fc23bf83f92a2e7de94dba0df48272cc3394
> 3rdparty/libprocess/src/metrics/metrics.cpp ba1962fa1aa96fa4153b95b7a5562ba46ab28b3b
> 3rdparty/libprocess/src/tests/statistics_tests.cpp a2a780bf9de018c823b68aa48977fd9fd1b8a064
>
>
> Diff: https://reviews.apache.org/r/68225/diff/2/
>
>
> Testing
> -------
>
> https://reviews.apache.org/r/68132/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 68225: Added 25th and 75th percentiles to
`Statistics`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68225/#review206891
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/include/process/statistics.hpp
Line 80 (original), 80-82 (patched)
<https://reviews.apache.org/r/68225/#comment290015>
Do you want a TODO to expose these in metrics snapshots? E.g.
```
T p25; // TODO(alexr): Expose this in metrics snapshots.
T p75; // TODO(alexr): Expose this in metrics snapshots.
```
Or just expose them in this patch?
3rdparty/libprocess/src/tests/statistics_tests.cpp
Lines 93-94 (original), 95-98 (patched)
<https://reviews.apache.org/r/68225/#comment290016>
We should probably have a test that maps p25 to 25, pXX to XX, etc to be more obviously correct. But certainly no need to touch it in this patch.
- Benjamin Mahler
On Aug. 6, 2018, 10:30 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68225/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2018, 10:30 a.m.)
>
>
> Review request for mesos, Benno Evers and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/statistics.hpp e9f1fc23bf83f92a2e7de94dba0df48272cc3394
> 3rdparty/libprocess/src/tests/statistics_tests.cpp a2a780bf9de018c823b68aa48977fd9fd1b8a064
>
>
> Diff: https://reviews.apache.org/r/68225/diff/1/
>
>
> Testing
> -------
>
> https://reviews.apache.org/r/68132/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 68225: Added 25th and 75th percentiles to
`Statistics`.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68225/#review206876
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On Aug. 6, 2018, 10:30 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68225/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2018, 10:30 a.m.)
>
>
> Review request for mesos, Benno Evers and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/statistics.hpp e9f1fc23bf83f92a2e7de94dba0df48272cc3394
> 3rdparty/libprocess/src/tests/statistics_tests.cpp a2a780bf9de018c823b68aa48977fd9fd1b8a064
>
>
> Diff: https://reviews.apache.org/r/68225/diff/1/
>
>
> Testing
> -------
>
> https://reviews.apache.org/r/68132/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 68225: Added 25th and 75th percentiles to
`Statistics`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68225/
-----------------------------------------------------------
(Updated Aug. 14, 2018, 12:47 p.m.)
Review request for mesos, Benno Evers and Benjamin Mahler.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/statistics.hpp e9f1fc23bf83f92a2e7de94dba0df48272cc3394
3rdparty/libprocess/src/metrics/metrics.cpp ba1962fa1aa96fa4153b95b7a5562ba46ab28b3b
3rdparty/libprocess/src/tests/statistics_tests.cpp a2a780bf9de018c823b68aa48977fd9fd1b8a064
Diff: https://reviews.apache.org/r/68225/diff/3/
Changes: https://reviews.apache.org/r/68225/diff/2-3/
Testing
-------
https://reviews.apache.org/r/68132/
Thanks,
Alexander Rukletsov
Re: Review Request 68225: Added 25th and 75th percentiles to
`Statistics`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68225/
-----------------------------------------------------------
(Updated Aug. 9, 2018, 2:21 p.m.)
Review request for mesos, Benno Evers and Benjamin Mahler.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/statistics.hpp e9f1fc23bf83f92a2e7de94dba0df48272cc3394
3rdparty/libprocess/src/metrics/metrics.cpp ba1962fa1aa96fa4153b95b7a5562ba46ab28b3b
3rdparty/libprocess/src/tests/statistics_tests.cpp a2a780bf9de018c823b68aa48977fd9fd1b8a064
Diff: https://reviews.apache.org/r/68225/diff/2/
Changes: https://reviews.apache.org/r/68225/diff/1-2/
Testing
-------
https://reviews.apache.org/r/68132/
Thanks,
Alexander Rukletsov