You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/05/30 19:06:05 UTC
[GitHub] [daffodil] dependabot[bot] opened a new pull request, #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
dependabot[bot] opened a new pull request, #798:
URL: https://github.com/apache/daffodil/pull/798
Bumps fedora-minimal from 35 to 36.
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on a diff in pull request #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #798:
URL: https://github.com/apache/daffodil/pull/798#discussion_r901838238
##########
containers/release-candidate/daffodil-release-candidate:
##########
@@ -281,6 +281,7 @@ case $PROJECT_REPO in
echo "Building Convenience Binaries..."
mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+ yarn install
Review Comment:
@Shanedell, this yarn install seems to be required now, is this documented anywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] Shanedell commented on a diff in pull request #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #798:
URL: https://github.com/apache/daffodil/pull/798#discussion_r901995107
##########
containers/release-candidate/daffodil-release-candidate:
##########
@@ -281,6 +281,7 @@ case $PROJECT_REPO in
echo "Building Convenience Binaries..."
mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+ yarn install
Review Comment:
@stevedlawrence Were you running a `yarn build` when you got the error? If so if is definetly something weird but if you tried running that `webpack` command on its own it may cause an error if you didn't build the source code yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] Shanedell commented on a diff in pull request #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #798:
URL: https://github.com/apache/daffodil/pull/798#discussion_r902598111
##########
containers/release-candidate/daffodil-release-candidate:
##########
@@ -281,6 +281,7 @@ case $PROJECT_REPO in
echo "Building Convenience Binaries..."
mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+ yarn install
Review Comment:
I know I bumped it must not have did it to the right version I will update that branch with 5.73.0 of webpack and adding that output.hashFunction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on a diff in pull request #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #798:
URL: https://github.com/apache/daffodil/pull/798#discussion_r901926438
##########
containers/release-candidate/daffodil-release-candidate:
##########
@@ -281,6 +281,7 @@ case $PROJECT_REPO in
echo "Building Convenience Binaries..."
mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+ yarn install
Review Comment:
Using your branch doesn't fix it. I found this active thread which seems like it's the issue:
https://togithub.com/webpack/webpack/issues/14532
According to that it's an issue with webpack and Node.js 17, but this update is to Fedora 36 which only includes Node.js 16. There are some comments that mention F36 not working, but no solution. Setting NODE_OPTIONS doesn't work for me in the VM, with the error:
```
node: --openssl-legacy-provider is not allowed in NODE_OPTIONS
```
Seems something else is going on...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on a diff in pull request #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #798:
URL: https://github.com/apache/daffodil/pull/798#discussion_r902600845
##########
containers/release-candidate/daffodil-release-candidate:
##########
@@ -281,6 +281,7 @@ case $PROJECT_REPO in
echo "Building Convenience Binaries..."
mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+ yarn install
Review Comment:
I think this is the commit in webpack that makes it so `output.hashFunction` is used everywhere:
https://github.com/webpack/webpack/commit/4a8bf4c084f98bef8b47f0050c352f246ffb3527
That was merged in 5.54.0, so we at least need that version for things to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on a diff in pull request #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #798:
URL: https://github.com/apache/daffodil/pull/798#discussion_r902594402
##########
containers/release-candidate/daffodil-release-candidate:
##########
@@ -281,6 +281,7 @@ case $PROJECT_REPO in
echo "Building Convenience Binaries..."
mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+ yarn install
Review Comment:
@Shanedell
I found steps that seems to fix this:
1. Update webpack to the very latest (5.73.0) as well as webpack-cli (4.10.0)
2. Set output.hashFunction to "sha512" in `build/extension.webpack.config.js`
Any reason why you didn't update webpack to 5.73.0 in your dependabot updates? It *think* we need at least something like 5.60 or something for the hashFunction change to work where we need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] Shanedell commented on a diff in pull request #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #798:
URL: https://github.com/apache/daffodil/pull/798#discussion_r902591436
##########
containers/release-candidate/daffodil-release-candidate:
##########
@@ -281,6 +281,7 @@ case $PROJECT_REPO in
echo "Building Convenience Binaries..."
mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+ yarn install
Review Comment:
Yeah that is something strange I can try to dig into it today based off of this branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence merged pull request #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
Posted by GitBox <gi...@apache.org>.
stevedlawrence merged PR #798:
URL: https://github.com/apache/daffodil/pull/798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] Shanedell commented on a diff in pull request #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #798:
URL: https://github.com/apache/daffodil/pull/798#discussion_r901905880
##########
containers/release-candidate/daffodil-release-candidate:
##########
@@ -281,6 +281,7 @@ case $PROJECT_REPO in
echo "Building Convenience Binaries..."
mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+ yarn install
Review Comment:
Did this also resolved that issue you had above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on a diff in pull request #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #798:
URL: https://github.com/apache/daffodil/pull/798#discussion_r902489299
##########
containers/release-candidate/daffodil-release-candidate:
##########
@@ -281,6 +281,7 @@ case $PROJECT_REPO in
echo "Building Convenience Binaries..."
mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+ yarn install
Review Comment:
This was when running `yarn build`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on pull request #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #798:
URL: https://github.com/apache/daffodil/pull/798#issuecomment-1160638442
@Shanedell, I get this error when doing a dry run release of the VS Code extension, any idea what the problem is?
Maybe one of the dependency updates in https://github.com/apache/daffodil-vscode/pull/187 will fix it?
```
$ webpack --mode production --config ./build/extension.webpack.config.js
/root/daffodil-vscode/node_modules/loader-runner/lib/LoaderRunner.js:133
if(isError) throw e;
^
Error: error:0308010C:digital envelope routines::unsupported
at new Hash (node:internal/crypto/hash:67:19)
at Object.createHash (node:crypto:130:10)
at module.exports (/root/daffodil-vscode/node_modules/webpack/lib/util/createHash.js:135:53)
at NormalModule._initBuildHash (/root/daffodil-vscode/node_modules/webpack/lib/NormalModule.js:417:16)
at handleParseError (/root/daffodil-vscode/node_modules/webpack/lib/NormalModule.js:471:10)
at /root/daffodil-vscode/node_modules/webpack/lib/NormalModule.js:503:5
at /root/daffodil-vscode/node_modules/webpack/lib/NormalModule.js:358:12
at /root/daffodil-vscode/node_modules/loader-runner/lib/LoaderRunner.js:373:3
at iterateNormalLoaders (/root/daffodil-vscode/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
at iterateNormalLoaders (/root/daffodil-vscode/node_modules/loader-runner/lib/LoaderRunner.js:221:10)
at /root/daffodil-vscode/node_modules/loader-runner/lib/LoaderRunner.js:236:3
at context.callback (/root/daffodil-vscode/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
at makeSourceMapAndFinish (/root/daffodil-vscode/node_modules/ts-loader/dist/index.js:58:5)
at successLoader (/root/daffodil-vscode/node_modules/ts-loader/dist/index.js:40:5)
at Object.loader (/root/daffodil-vscode/node_modules/ts-loader/dist/index.js:23:5)
at LOADER_EXECUTION (/root/daffodil-vscode/node_modules/loader-runner/lib/LoaderRunner.js:119:14)
at runSyncOrAsync (/root/daffodil-vscode/node_modules/loader-runner/lib/LoaderRunner.js:120:4)
at iterateNormalLoaders (/root/daffodil-vscode/node_modules/loader-runner/lib/LoaderRunner.js:232:2)
at Array.<anonymous> (/root/daffodil-vscode/node_modules/loader-runner/lib/LoaderRunner.js:205:4)
at Storage.finished (/root/daffodil-vscode/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:55:16)
at /root/daffodil-vscode/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:91:9
at /root/daffodil-vscode/node_modules/graceful-fs/graceful-fs.js:123:16
at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read_file_context:68:3) {
opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
library: 'digital envelope routines',
reason: 'unsupported',
code: 'ERR_OSSL_EVP_UNSUPPORTED'
}
error Command failed with exit code 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on a diff in pull request #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #798:
URL: https://github.com/apache/daffodil/pull/798#discussion_r901914594
##########
containers/release-candidate/daffodil-release-candidate:
##########
@@ -281,6 +281,7 @@ case $PROJECT_REPO in
echo "Building Convenience Binaries..."
mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+ yarn install
Review Comment:
No, i still get the error with yarn install. I found some references that said it has to do with webpack 4 and newer versions of Node.js. So maybe your PR that updates the webpack version will fix it. I'll try a dry run from that branch and see if it fixes it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] Shanedell commented on a diff in pull request #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #798:
URL: https://github.com/apache/daffodil/pull/798#discussion_r901891843
##########
containers/release-candidate/daffodil-release-candidate:
##########
@@ -281,6 +281,7 @@ case $PROJECT_REPO in
echo "Building Convenience Binaries..."
mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+ yarn install
Review Comment:
I don't believe I can update the README in a PR if you would like
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on a diff in pull request #798: Bump fedora-minimal from 35 to 36 in /containers/release-candidate
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #798:
URL: https://github.com/apache/daffodil/pull/798#discussion_r901892423
##########
containers/release-candidate/daffodil-release-candidate:
##########
@@ -281,6 +281,7 @@ case $PROJECT_REPO in
echo "Building Convenience Binaries..."
mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+ yarn install
Review Comment:
Please do. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org