You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/25 01:38:37 UTC

[GitHub] [apisix] tokers commented on a change in pull request #6442: Docs: refactor document

tokers commented on a change in pull request #6442:
URL: https://github.com/apache/apisix/pull/6442#discussion_r814408822



##########
File path: docs/en/latest/how-to-build.md
##########
@@ -119,7 +119,11 @@ Follow the steps below to install Apache APISIX via the source release package.
 
   **Note**: If `make deps` fails with "install `lualdap` failed" with an error like `Could not find header file for LDAP` try the solution below.
 
-  Solution: Set `LDAP_DIR` with `luarocks config` manually. For example `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`.
+      Solution: luarocks supports adding custom package addresses to the project. You can set `LDAP_DIR` with `luarocks config` manually, for example `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`. You should config as follows:

Review comment:
       
   ```suggestion
         Solution: luarocks supports adding custom package filepaths to the project. You can set `LDAP_DIR` with `luarocks config` manually, for example `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`. You should config as follows:
   ```

##########
File path: docs/en/latest/how-to-build.md
##########
@@ -119,7 +119,11 @@ Follow the steps below to install Apache APISIX via the source release package.
 
   **Note**: If `make deps` fails with "install `lualdap` failed" with an error like `Could not find header file for LDAP` try the solution below.
 
-  Solution: Set `LDAP_DIR` with `luarocks config` manually. For example `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`.
+      Solution: luarocks supports adding custom package addresses to the project. You can set `LDAP_DIR` with `luarocks config` manually, for example `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`. You should config as follows:
+      1. Install `openldap` locally using tools including but not limited to 'brew';

Review comment:
       Since you mention the `brew`, let's also give an example to use `brew` to install openldap.

##########
File path: docs/en/latest/how-to-build.md
##########
@@ -119,7 +119,11 @@ Follow the steps below to install Apache APISIX via the source release package.
 
   **Note**: If `make deps` fails with "install `lualdap` failed" with an error like `Could not find header file for LDAP` try the solution below.
 
-  Solution: Set `LDAP_DIR` with `luarocks config` manually. For example `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`.
+      Solution: luarocks supports adding custom package addresses to the project. You can set `LDAP_DIR` with `luarocks config` manually, for example `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`. You should config as follows:
+      1. Install `openldap` locally using tools including but not limited to 'brew';
+      2. Locate the 'openldap' local installation directory. Note that the default address for 'brew' in macOS for ARM architecture is '/opt/homebrew/cellar/', and macOS for x86 architecture defaults to '/usr/local/opt/';

Review comment:
       Can we give a command to locate the directory? Or we may have to update this statement after the new macos release.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org