You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by "David Blevins (JIRA)" <ji...@apache.org> on 2009/09/04 03:32:57 UTC
[jira] Created: (OWB-134) Remaining 299 draft spec API changes
Remaining 299 draft spec API changes
------------------------------------
Key: OWB-134
URL: https://issues.apache.org/jira/browse/OWB-134
Project: OpenWebBeans
Issue Type: Task
Reporter: David Blevins
Assignee: Gurkan Erdogdu
Still some API changes needed after the 330 impact on the 299 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OWB-134) Remaining 299 draft spec API changes
Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gurkan Erdogdu closed OWB-134.
------------------------------
Resolution: Fixed
Fix Version/s: M3
> Remaining 299 draft spec API changes
> ------------------------------------
>
> Key: OWB-134
> URL: https://issues.apache.org/jira/browse/OWB-134
> Project: OpenWebBeans
> Issue Type: Task
> Reporter: David Blevins
> Assignee: Gurkan Erdogdu
> Fix For: M3
>
> Attachments: OWB-134-samples.patch.txt, OWB-134.patch.txt
>
>
> Still some API changes needed after the 330 impact on the 299 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-134) Remaining 299 draft spec API changes
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751342#action_12751342 ]
Mark Struberg commented on OWB-134:
-----------------------------------
yea cool patch - txs!
Hmm David, since OpenEjb is reasonably stable, may we ask you to become an OWB committer too?
It would be a huge honour for us, and hacking on DIs seems to be one of your favourite areas anyway ;)
> Remaining 299 draft spec API changes
> ------------------------------------
>
> Key: OWB-134
> URL: https://issues.apache.org/jira/browse/OWB-134
> Project: OpenWebBeans
> Issue Type: Task
> Reporter: David Blevins
> Assignee: Gurkan Erdogdu
> Attachments: OWB-134-samples.patch.txt, OWB-134.patch.txt
>
>
> Still some API changes needed after the 330 impact on the 299 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OWB-134) Remaining 299 draft spec API changes
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Blevins updated OWB-134:
------------------------------
Attachment: OWB-134-samples.patch.txt
> Remaining 299 draft spec API changes
> ------------------------------------
>
> Key: OWB-134
> URL: https://issues.apache.org/jira/browse/OWB-134
> Project: OpenWebBeans
> Issue Type: Task
> Reporter: David Blevins
> Assignee: Gurkan Erdogdu
> Attachments: OWB-134-samples.patch.txt, OWB-134.patch.txt
>
>
> Still some API changes needed after the 330 impact on the 299 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-134) Remaining 299 draft spec API changes
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751354#action_12751354 ]
David Blevins commented on OWB-134:
-----------------------------------
Sure, I'd be happy to be a commiter if you all think I'm ready. Fine waiting too. No rush.
> Remaining 299 draft spec API changes
> ------------------------------------
>
> Key: OWB-134
> URL: https://issues.apache.org/jira/browse/OWB-134
> Project: OpenWebBeans
> Issue Type: Task
> Reporter: David Blevins
> Assignee: Gurkan Erdogdu
> Attachments: OWB-134-samples.patch.txt, OWB-134.patch.txt
>
>
> Still some API changes needed after the 330 impact on the 299 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OWB-134) Remaining 299 draft spec API changes
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Blevins updated OWB-134:
------------------------------
Attachment: OWB-134.patch.txt
This is a rather large patch. I would not be the least bit offended if it was not applied due to size. I got started updating one thing and then just couldn't stop myself :)
Here are the refactors I went through to bring the code up to the latest API changes. Should help with reviewing. Also good information if you'd rather do the refactors incrementally or differently instead of as one big patch.
----
CLASS RENAMES
@InterceptorBindingType -> @InterceptorBinding
Notify -> Reception
API METHOD RENAMES
Bean
- getBindingTypes() -> getQualifiers()
- getScopeTypes() -> getScopes()
Context
- getScopeType() -> getScope()
BeanManager
- isInterceptorBindingType() -> isInterceptorBinding()
- getInterceptorBindingTypeDefinition() -> getInterceptorBindingDefinition()
BeforeBeanDiscovery
- addBindingType() -> addQualifier()
- addInterceptorBindingType() -> addInterceptorBindingType()
Decorator
- getDelegateBindingTypes() -> getDelegateQualifiers()
InjectionPoint
- getBindingTypes() -> getQualifiers()
Interceptor
- getInterceptorBindingTypes() - getInterceptorBindings()
ObserverMethod
- getObservedBindings() -> getObservedQualifiers()
- getNotify() -> getReception()
EXCEPTION TEXT
@ScopeType in text -> @Scope
@BindingType in text -> @Qualifier
@InterceptorBindingType in text -> @InterceptorBinding
INTERNAL METHOD RENAMES
AbstractBean
- getImplBindingTypes -> getImplQualifiers()
- addBindingType() -> addQualifier()
BeanCreator
- defineBindingType() -> defineQualifier()
DefinitionUtil
- defineBindingTypes() -> defineQualifiers()
AnnotationUtil
- isBindingAnnotation() -> isQualifierAnnotation()
- getBindingAnnotation() -> getQualifierAnnotations()
- getMethodFirstParameterBindingTypesWithGivenAnnotation() -> getMethodFirstParameterQualifierWithGivenAnnotation()
- checkBindingTypeConditions() -> checkQualifierConditions()
- isAnyBindingExist() -> isAnyQualifierExist()
IBeanInheritedMetaData
- getInheritedBindingTypes() -> getInheritedQualifiers()
- getInheritedInterceptorBindingTypes() -> getInheritedInterceptorBindings()
InstanceImpl
- getAdditionalBindings() -> getAdditionalQualifiers()
ObserverWrapper
- getEventBindingTypes() -> getEventQualifiers()
- isObserverOfBindings() -> isObserverOfQualifiers()
WebBeansInterceptor
- addInterceptorBindingType() -> addInterceptorBinding()
- isBindingTypesExist() -> isBindingExist()
WebBeansUtil
- checkForNewBindingForDeployment() -> checkForNewQualifierForDeployment()
All relating parameter names, variable names and javadoc was updated as well. Most of it anyways.
> Remaining 299 draft spec API changes
> ------------------------------------
>
> Key: OWB-134
> URL: https://issues.apache.org/jira/browse/OWB-134
> Project: OpenWebBeans
> Issue Type: Task
> Reporter: David Blevins
> Assignee: Gurkan Erdogdu
> Attachments: OWB-134.patch.txt
>
>
> Still some API changes needed after the 330 impact on the 299 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.