You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rohit Yadav <bh...@apache.org> on 2014/12/05 19:34:01 UTC

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17747/#review64041
-----------------------------------------------------------


Hari, your fix is already on 4.3; but not on 4.4, 4.5 or master. Can you please see that?

I see a patch from Daan on 4.4, 4.5 and master: 0839fbce67963578a18478f90e5fbcfd7be11912

Please advise changes if any on all these branches. Thanks.

- Rohit Yadav


On Oct. 9, 2014, 9:27 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17747/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 9:27 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-6023
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6023
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6023: Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits
> 
> Changed the VCPU max limit to 16 and provided a cluster level configuration parameter for this max limit named xen.vm.vcpu.max
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/agent/api/to/VirtualMachineTO.java 4b36df5 
>   plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java c1de8bb 
>   plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java e3c3943 
> 
> Diff: https://reviews.apache.org/r/17747/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>