You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/31 11:14:46 UTC

[GitHub] [shardingsphere] sandynz commented on a diff in pull request #21858: Upgrade the version of elasticjob

sandynz commented on code in PR #21858:
URL: https://github.com/apache/shardingsphere/pull/21858#discussion_r1009066669


##########
.github/workflows/it-scaling.yml:
##########
@@ -56,6 +56,7 @@ on:
       - 'test/integration-test/env/**'
       - 'test/integration-test/scaling/**'
       - '!*.md'
+      - 'pom.xml'

Review Comment:
   It's better not add `pom.xml`, since most version change doesn't affect scaling features, but it might trigger unnecessary scaling IT which cost much time



##########
pom.xml:
##########
@@ -84,7 +84,7 @@
         <curator.version>5.3.0</curator.version>
         <jetcd.version>0.7.3</jetcd.version>
         
-        <elasticjob.version>3.0.1</elasticjob.version>
+        <elasticjob.version>3.0.2</elasticjob.version>

Review Comment:
   version could be updated in LICENSE, seems 2 files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org