You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2013/09/13 02:39:24 UTC
Review Request 14117: OOZIE-1528: CoordRerunX and ActionEndX not updating
some of the modified beans
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14117/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1528
https://issues.apache.org/jira/browse/OOZIE-1528
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1528
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1521980
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1521980
trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521980
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1521980
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1521980
trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521980
trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java 1521980
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1521980
Diff: https://reviews.apache.org/r/14117/diff/
Testing
-------
Thanks,
Virag Kothari
Re: Review Request 14117: OOZIE-1528: CoordRerunX and ActionEndX not
updating some of the modified beans
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14117/#review26080
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/service/JPAService.java
<https://reviews.apache.org/r/14117/#comment50910>
Can we just reuse
E0100(XLog.OPS, "Could not initialize service [{0}], {1}"),
instead of introducing another one.
trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java
<https://reviews.apache.org/r/14117/#comment50909>
Pass the permission also as argument to recursiveChangePermissions instead of doing FsPermission.valueOf(PERMISSION_STRING) inside the method everytime
- Rohini Palaniswamy
On Sept. 13, 2013, 12:39 a.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14117/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 12:39 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1528
> https://issues.apache.org/jira/browse/OOZIE-1528
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1528
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1521980
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1521980
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521980
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1521980
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1521980
> trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521980
> trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java 1521980
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1521980
>
> Diff: https://reviews.apache.org/r/14117/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request 14117: OOZIE-1528: CoordRerunX and ActionEndX not
updating some of the modified beans
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14117/#review26084
-----------------------------------------------------------
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java
<https://reviews.apache.org/r/14117/#comment50916>
there is another query checking stats.
can we set dummyStats in XDataTestCase.createWorkflowAction ?
- Ryota Egashira
On Sept. 13, 2013, 12:39 a.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14117/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 12:39 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1528
> https://issues.apache.org/jira/browse/OOZIE-1528
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1528
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1521980
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1521980
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521980
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1521980
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1521980
> trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521980
> trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java 1521980
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1521980
>
> Diff: https://reviews.apache.org/r/14117/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request 14117: OOZIE-1528: CoordRerunX and ActionEndX not
updating some of the modified beans
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14117/#review26095
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
<https://reviews.apache.org/r/14117/#comment50942>
Both are being set again on rerun. RunConf is basically a merge of created conf and local properties of wf. So it needs to be reset. CreatedConf is not updated again, but as its being reset by Rerun, I am including in the update to be safe.
- Virag Kothari
On Sept. 13, 2013, 6:56 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14117/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 6:56 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1528
> https://issues.apache.org/jira/browse/OOZIE-1528
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1528
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1521980
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1521980
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521980
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1521980
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1521980
> trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521980
> trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java 1521980
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1521980
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1521980
>
> Diff: https://reviews.apache.org/r/14117/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request 14117: OOZIE-1528: CoordRerunX and ActionEndX not
updating some of the modified beans
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14117/#review26158
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Sept. 16, 2013, 10:05 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14117/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2013, 10:05 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1528
> https://issues.apache.org/jira/browse/OOZIE-1528
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1528
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1521980
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521980
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1521980
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1521980
> trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521980
> trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java 1521980
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1521980
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1521980
>
> Diff: https://reviews.apache.org/r/14117/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request 14117: OOZIE-1528: CoordRerunX and ActionEndX not
updating some of the modified beans
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14117/
-----------------------------------------------------------
(Updated Sept. 16, 2013, 10:05 p.m.)
Review request for oozie.
Changes
-------
Added 'userretrycount' to update for wf action check
Bugs: OOZIE-1528
https://issues.apache.org/jira/browse/OOZIE-1528
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1528
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1521980
trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521980
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1521980
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1521980
trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521980
trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java 1521980
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1521980
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1521980
Diff: https://reviews.apache.org/r/14117/diff/
Testing
-------
Thanks,
Virag Kothari
Re: Review Request 14117: OOZIE-1528: CoordRerunX and ActionEndX not
updating some of the modified beans
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14117/#review26098
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java
<https://reviews.apache.org/r/14117/#comment50944>
FsPermission perms in method argument instead of string
- Rohini Palaniswamy
On Sept. 13, 2013, 6:56 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14117/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 6:56 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1528
> https://issues.apache.org/jira/browse/OOZIE-1528
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1528
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1521980
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1521980
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521980
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1521980
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1521980
> trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521980
> trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java 1521980
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1521980
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1521980
>
> Diff: https://reviews.apache.org/r/14117/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request 14117: OOZIE-1528: CoordRerunX and ActionEndX not
updating some of the modified beans
Posted by Virag Kothari <vi...@yahoo-inc.com>.
> On Sept. 13, 2013, 7:32 p.m., Mona Chitnis wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java, line 58
> > <https://reviews.apache.org/r/14117/diff/2/?file=352072#file352072line58>
> >
> > Doesnt this need writable permissions? rwxrwxr-x?
writable by group is not required
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14117/#review26093
-----------------------------------------------------------
On Sept. 13, 2013, 6:56 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14117/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 6:56 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1528
> https://issues.apache.org/jira/browse/OOZIE-1528
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1528
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1521980
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1521980
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521980
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1521980
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1521980
> trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521980
> trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java 1521980
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1521980
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1521980
>
> Diff: https://reviews.apache.org/r/14117/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request 14117: OOZIE-1528: CoordRerunX and ActionEndX not
updating some of the modified beans
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14117/#review26093
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
<https://reviews.apache.org/r/14117/#comment50931>
do we need both createdConf and runConf to be updated? Can you elaborate on which client-facing field each one serves?
trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java
<https://reviews.apache.org/r/14117/#comment50932>
Doesnt this need writable permissions? rwxrwxr-x?
- Mona Chitnis
On Sept. 13, 2013, 6:56 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14117/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 6:56 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1528
> https://issues.apache.org/jira/browse/OOZIE-1528
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1528
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1521980
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1521980
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521980
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1521980
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1521980
> trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521980
> trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java 1521980
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1521980
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1521980
>
> Diff: https://reviews.apache.org/r/14117/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request 14117: OOZIE-1528: CoordRerunX and ActionEndX not
updating some of the modified beans
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14117/
-----------------------------------------------------------
(Updated Sept. 13, 2013, 6:56 p.m.)
Review request for oozie.
Changes
-------
Addressed rohini and ryota's comments
Bugs: OOZIE-1528
https://issues.apache.org/jira/browse/OOZIE-1528
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1528
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1521980
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1521980
trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521980
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1521980
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1521980
trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521980
trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java 1521980
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1521980
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1521980
Diff: https://reviews.apache.org/r/14117/diff/
Testing
-------
Thanks,
Virag Kothari