[jira] [Commented] (TC-535) DS URL sig key apis needs to have tenancy check in place

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131288#comment-16131288 ] 

ASF GitHub Bot commented on TC-535:
-----------------------------------

GitHub user nir-sopher opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/831

    [TC-535] url sig - tenancy checks

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nir-sopher/incubator-trafficcontrol tc-535

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/831.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #831
    
----
commit ef783a34b16d6ee53b6520b49e9934a8f295cbb4
Author: nir-sopher <ni...@qwilt.com>
Date:   2017-08-13T15:25:37Z

    url sig - tenancy checks

----


> DS URL sig key apis needs to have tenancy check in place
> --------------------------------------------------------
>
>                 Key: TC-535
>                 URL: https://issues.apache.org/jira/browse/TC-535
>             Project: Traffic Control
>          Issue Type: Bug
>          Components: Traffic Ops API
>    Affects Versions: 2.1.0
>            Reporter: Jeremy Mitchell
>            Assignee: Nir Sopher
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the use_tenancy parameter but when activated it is used to limit the scope of delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's that they don't have access to.
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/generate
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
> get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)