[jira] [Commented] (PARQUET-1954) TCP connection leak in parquet dump

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258586#comment-17258586 ] 

ASF GitHub Bot commented on PARQUET-1954:
-----------------------------------------

shangxinli commented on pull request #849:
URL: https://github.com/apache/parquet-mr/pull/849#issuecomment-754286697


   Good catch! Thanks for the effort! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> TCP connection leak in parquet dump
> -----------------------------------
>
>                 Key: PARQUET-1954
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1954
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-mr
>            Reporter: xiepengjie
>            Priority: Major
>
> Hi,
> When i'm trying to dump a parquet file, i find the TCP connection leak in org.apache.parquet.tools.command.DumpCommand#dump :
>  
> {code:java}
> ...
> ParquetFileReader freader = null;
> if (showmd) {
>     try {
>         long group = 0;
>         for (BlockMetaData block : blocks) {
>             ...
>             freader = new ParquetFileReader(
>                 conf, meta.getFileMetaData(), inpath, rblocks, columns);
>             ...
>             out.flushColumns();
>         }
>     } finally {
>         if (freader != null) {
>             freader.close();
>         }
>     }
> }
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)