You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by we...@apache.org on 2018/11/16 04:47:08 UTC
spark git commit: [SPARK-23207][SQL][FOLLOW-UP] Use
`SQLConf.get.enableRadixSort` instead of
`SparkEnv.get.conf.get(SQLConf.RADIX_SORT_ENABLED)`.
Repository: spark
Updated Branches:
refs/heads/master 3649fe599 -> dad2d826a
[SPARK-23207][SQL][FOLLOW-UP] Use `SQLConf.get.enableRadixSort` instead of `SparkEnv.get.conf.get(SQLConf.RADIX_SORT_ENABLED)`.
## What changes were proposed in this pull request?
This is a follow-up of #20393.
We should read the conf `"spark.sql.sort.enableRadixSort"` from `SQLConf` instead of `SparkConf`, i.e., use `SQLConf.get.enableRadixSort` instead of `SparkEnv.get.conf.get(SQLConf.RADIX_SORT_ENABLED)`, otherwise the config is never read.
## How was this patch tested?
Existing tests.
Closes #23046 from ueshin/issues/SPARK-23207/conf.
Authored-by: Takuya UESHIN <ue...@databricks.com>
Signed-off-by: Wenchen Fan <we...@databricks.com>
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/dad2d826
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/dad2d826
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/dad2d826
Branch: refs/heads/master
Commit: dad2d826ae9138f06751e5d092531a9e06028c21
Parents: 3649fe5
Author: Takuya UESHIN <ue...@databricks.com>
Authored: Fri Nov 16 12:46:57 2018 +0800
Committer: Wenchen Fan <we...@databricks.com>
Committed: Fri Nov 16 12:46:57 2018 +0800
----------------------------------------------------------------------
.../apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/dad2d826/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
index 3b6eebd..d6742ab 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
@@ -280,7 +280,7 @@ object ShuffleExchangeExec {
}
// The comparator for comparing row hashcode, which should always be Integer.
val prefixComparator = PrefixComparators.LONG
- val canUseRadixSort = SparkEnv.get.conf.get(SQLConf.RADIX_SORT_ENABLED)
+ val canUseRadixSort = SQLConf.get.enableRadixSort
// The prefix computer generates row hashcode as the prefix, so we may decrease the
// probability that the prefixes are equal when input rows choose column values from a
// limited range.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org