Re: Review Request: OOZIE-814 Add support of configuring db's schema in JPAService for oozie

[Alejandro Abdelnur <tu...@cloudera.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4755/#review8371
-----------------------------------------------------------


Han Xiao,

First of all, apologies for the delay.

I've done an initial testing using derby and the DB create seems OK. The upgrade (from an oozie2) fails with the following error:


Error: DB schema does not exist

--------------------------------------
java.lang.Exception: DB schema does not exist
	at org.apache.oozie.tools.OozieDBCLI.validateDBSchema(OozieDBCLI.java:402)
	at org.apache.oozie.tools.OozieDBCLI.upgradeDBTo32(OozieDBCLI.java:202)
	at org.apache.oozie.tools.OozieDBCLI.upgradeDB(OozieDBCLI.java:197)
	at org.apache.oozie.tools.OozieDBCLI.run(OozieDBCLI.java:124)
	at org.apache.oozie.tools.OozieDBCLI.main(OozieDBCLI.java:72)
--------------------------------------

It seems that the upgrade expect the 'oozie' schema name when there is not schema name. How do you suggest to handle that?

Tomorrow I'll test it with Oracle/MySQL/Postgress.

Also, please upload the patch directly to the JIRA, we are not using reviewboard anymore.

thx

- Alejandro Abdelnur


On May 28, 2012, 7:52 a.m., Han Xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4755/
> -----------------------------------------------------------
> 
> (Updated May 28, 2012, 7:52 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> Oozie's JPA service doesn't support configure different schemas for oozie's db.
> Our company wants to use one db for multi oozie clusters, and then we want each oozie cluster can use different schema of the db. Therefore JPAService in oozie should support to configure the schema of the db, not just the database.
> The oozie.db.schema.name is use to configure oozie's db name, however, it is a little confusing for it is not used to configure the actually schema of db.
> 
> 
> This addresses bug OOZIE-814.
>     https://issues.apache.org/jira/browse/OOZIE-814
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/conf/oozie-site.xml 1339440 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/SystemInfoBean.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1339440 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/META-INF/persistence.xml 1339440 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml 1339440 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/docs/src/site/twiki/AG_Install.twiki 1339440 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 1343152 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/utils/dbutils/updatescripts/readme.txt 1339440 
> 
> Diff: https://reviews.apache.org/r/4755/diff/
> 
> 
> Testing
> -------
> 
> * Deployed Oozie, added oozie.db.schema.name configs values, succeed to run the examples on Derby and Postgres databases.
> 
> 
> Thanks,
> 
> Han Xiao
> 
>