[GitHub] [dolphinscheduler] SbloodyS commented on a change in pull request #8066: [Feature-7993][E2E] Replace HDFS image with MinIO S3 image

[GitBox <gi...@apache.org>]

SbloodyS commented on a change in pull request #8066:
URL: https://github.com/apache/dolphinscheduler/pull/8066#discussion_r785588856



##########
File path: dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/resources/docker/file-manage/common.properties
##########
@@ -46,16 +46,16 @@ kerberos.expire.time=2
 hdfs.root.user=hdfs
 
 # if resource.storage.type=S3, the value like: s3a://dolphinscheduler; if resource.storage.type=HDFS and namenode HA is enabled, you need to copy core-site.xml and hdfs-site.xml to conf dir
-fs.defaultFS=hdfs://hdfs:8020
+fs.defaultFS=s3a://dolphinscheduler
 
 # if resource.storage.type=S3, s3 endpoint
-fs.s3a.endpoint=http://192.168.xx.xx:9010
+fs.s3a.endpoint=http://10.1.0.1:9000

Review comment:
       No, We can't. It may cause UnknownHostException by using http://s3:9000. Because s3 use virtual-hosted style subdomains to verify connection information. 
   
   Related articles:
   https://aws.amazon.com/cn/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org