You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directmemory.apache.org by bp...@apache.org on 2012/02/24 15:40:33 UTC
svn commit: r1293273 -
/incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java
Author: bperroud
Date: Fri Feb 24 14:40:33 2012
New Revision: 1293273
URL: http://svn.apache.org/viewvc?rev=1293273&view=rev
Log:
DIRECTMEMORY-71 : preserve initial logic
Modified:
incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java
Modified: incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java
URL: http://svn.apache.org/viewvc/incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java?rev=1293273&r1=1293272&r2=1293273&view=diff
==============================================================================
--- incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java (original)
+++ incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java Fri Feb 24 14:40:33 2012
@@ -107,15 +107,14 @@ public class SolrOffHeapCache<K, V>
Serializer serializer = null;
try
{
-
serializer = SerializerFactory.createNewSerializer( serializerClassName );
}
catch ( SerializerNotFoundException e )
{
- // ignore and revert to default one
- // TODO olamy log that ?
+ log.warn("Serializer not found for class " + serializerClassName +
+ ", falling back to the default serializer");
+ serializer = SerializerFactory.createNewSerializer();
}
- serializer = SerializerFactory.createNewSerializer();
cacheService.setSerializer( serializer );
}
Re: svn commit: r1293273 - /incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java
Posted by Simone Tripodi <si...@apache.org>.
pas de problemes, my mistake was the bad one, not yours ;)
merci,
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Fri, Feb 24, 2012 at 4:22 PM, Benoit Perroud <be...@noisette.ch> wrote:
> Arf, thanks for the remark. Switching from one project to another
> without the same formatting... Sorry !
>
> I will correct that.
>
> Cheers
>
> Benoit.
>
>
> 2012/2/24 Simone Tripodi <si...@apache.org>:
>> merci, that is the way to go!
>>
>> apologize for the breakage ;(
>>
>> can you please turn off the TABS from the format?
>> TIA!
>> -Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>>
>>
>> On Fri, Feb 24, 2012 at 3:40 PM, <bp...@apache.org> wrote:
>>> Author: bperroud
>>> Date: Fri Feb 24 14:40:33 2012
>>> New Revision: 1293273
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1293273&view=rev
>>> Log:
>>> DIRECTMEMORY-71 : preserve initial logic
>>>
>>> Modified:
>>> incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java
>>>
>>> Modified: incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java
>>> URL: http://svn.apache.org/viewvc/incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java?rev=1293273&r1=1293272&r2=1293273&view=diff
>>> ==============================================================================
>>> --- incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java (original)
>>> +++ incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java Fri Feb 24 14:40:33 2012
>>> @@ -107,15 +107,14 @@ public class SolrOffHeapCache<K, V>
>>> Serializer serializer = null;
>>> try
>>> {
>>> -
>>> serializer = SerializerFactory.createNewSerializer( serializerClassName );
>>> }
>>> catch ( SerializerNotFoundException e )
>>> {
>>> - // ignore and revert to default one
>>> - // TODO olamy log that ?
>>> + log.warn("Serializer not found for class " + serializerClassName +
>>> + ", falling back to the default serializer");
>>> + serializer = SerializerFactory.createNewSerializer();
>>> }
>>> - serializer = SerializerFactory.createNewSerializer();
>>>
>>> cacheService.setSerializer( serializer );
>>> }
>>>
>>>
>
>
>
> --
> sent from my Nokia 3210
Re: svn commit: r1293273 - /incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java
Posted by Benoit Perroud <be...@noisette.ch>.
Arf, thanks for the remark. Switching from one project to another
without the same formatting... Sorry !
I will correct that.
Cheers
Benoit.
2012/2/24 Simone Tripodi <si...@apache.org>:
> merci, that is the way to go!
>
> apologize for the breakage ;(
>
> can you please turn off the TABS from the format?
> TIA!
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
>
> On Fri, Feb 24, 2012 at 3:40 PM, <bp...@apache.org> wrote:
>> Author: bperroud
>> Date: Fri Feb 24 14:40:33 2012
>> New Revision: 1293273
>>
>> URL: http://svn.apache.org/viewvc?rev=1293273&view=rev
>> Log:
>> DIRECTMEMORY-71 : preserve initial logic
>>
>> Modified:
>> incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java
>>
>> Modified: incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java
>> URL: http://svn.apache.org/viewvc/incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java?rev=1293273&r1=1293272&r2=1293273&view=diff
>> ==============================================================================
>> --- incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java (original)
>> +++ incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java Fri Feb 24 14:40:33 2012
>> @@ -107,15 +107,14 @@ public class SolrOffHeapCache<K, V>
>> Serializer serializer = null;
>> try
>> {
>> -
>> serializer = SerializerFactory.createNewSerializer( serializerClassName );
>> }
>> catch ( SerializerNotFoundException e )
>> {
>> - // ignore and revert to default one
>> - // TODO olamy log that ?
>> + log.warn("Serializer not found for class " + serializerClassName +
>> + ", falling back to the default serializer");
>> + serializer = SerializerFactory.createNewSerializer();
>> }
>> - serializer = SerializerFactory.createNewSerializer();
>>
>> cacheService.setSerializer( serializer );
>> }
>>
>>
--
sent from my Nokia 3210
Re: svn commit: r1293273 - /incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java
Posted by Simone Tripodi <si...@apache.org>.
merci, that is the way to go!
apologize for the breakage ;(
can you please turn off the TABS from the format?
TIA!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Fri, Feb 24, 2012 at 3:40 PM, <bp...@apache.org> wrote:
> Author: bperroud
> Date: Fri Feb 24 14:40:33 2012
> New Revision: 1293273
>
> URL: http://svn.apache.org/viewvc?rev=1293273&view=rev
> Log:
> DIRECTMEMORY-71 : preserve initial logic
>
> Modified:
> incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java
>
> Modified: incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java
> URL: http://svn.apache.org/viewvc/incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java?rev=1293273&r1=1293272&r2=1293273&view=diff
> ==============================================================================
> --- incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java (original)
> +++ incubator/directmemory/trunk/integrations/solr/src/main/java/org/apache/directmemory/examples/solr/SolrOffHeapCache.java Fri Feb 24 14:40:33 2012
> @@ -107,15 +107,14 @@ public class SolrOffHeapCache<K, V>
> Serializer serializer = null;
> try
> {
> -
> serializer = SerializerFactory.createNewSerializer( serializerClassName );
> }
> catch ( SerializerNotFoundException e )
> {
> - // ignore and revert to default one
> - // TODO olamy log that ?
> + log.warn("Serializer not found for class " + serializerClassName +
> + ", falling back to the default serializer");
> + serializer = SerializerFactory.createNewSerializer();
> }
> - serializer = SerializerFactory.createNewSerializer();
>
> cacheService.setSerializer( serializer );
> }
>
>