You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/05/05 08:43:21 UTC
[GitHub] [thrift] emmenlau opened a new pull request #2383: Minor cleanup of two CMake files, and removed (unused) boost deps
emmenlau opened a new pull request #2383:
URL: https://github.com/apache/thrift/pull/2383
This PR adds a trivial cleanup of two cmake files. It contains mostly whitespace changes to fix indenting and syntax in cmake. It also removes some unused boost dependencies.
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on pull request #2383: Minor cleanup of two CMake files, and removed (unused) boost deps
Posted by GitBox <gi...@apache.org>.
emmenlau commented on pull request #2383:
URL: https://github.com/apache/thrift/pull/2383#issuecomment-854457565
All build errors are unrelated, indicating that the removal of boost in the one test is fine! All other changes are whitespace cleanup. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau merged pull request #2383: Minor cleanup of two CMake files, and removed (unused) boost deps
Posted by GitBox <gi...@apache.org>.
emmenlau merged pull request #2383:
URL: https://github.com/apache/thrift/pull/2383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org