[GitHub] [ignite-3] rpuch commented on a change in pull request #670: IGNITE-15948 Basic class structure change handling

[GitBox <gi...@apache.org>]

rpuch commented on a change in pull request #670:
URL: https://github.com/apache/ignite-3/pull/670#discussion_r809932007



##########
File path: modules/network/src/main/java/org/apache/ignite/internal/network/serialization/ClassDescriptor.java
##########
@@ -52,21 +52,28 @@
     @Nullable
     private final ClassDescriptor superClassDescriptor;
 
+    /**
+     * Component type descriptor (only present for arrays).
+     */
+    @Nullable
+    private final ClassDescriptor componentTypeDescriptor;
+
+    private final boolean isPrimitive;

Review comment:
       They do not need javadocs, the name seems to be sufficient. Some fields need javadocs because they are not so obvious. I think it's a good idea to do this selectively.
   As for the newlines, I use them here for grouping fields. In this case, the 4 fields constitute a group, they look as one block, it's intentional.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org