You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2026/09/04 04:59:24 UTC
[PR] fix(release): set the macOS deployment target for the x86_64 wheel build [hudi-rs]
yihua opened a new pull request, #722:
URL: https://github.com/apache/hudi-rs/pull/722
## Description
A dry run of the release wheel matrix (requested in the 0.5.0 validation on #713) caught a publish-time failure: the x86_64-apple-darwin wheel fails to compile RocksDB because the build runs at rustc's 10.12 deployment floor when `MACOSX_DEPLOYMENT_TARGET` is unset, and RocksDB uses C++17 aligned allocation, available from macOS 10.13. This is the first release that compiles the spill tier on that target, so the tagged publish would have died mid-release. The fix sets the floor explicitly per matrix target: 10.13 for x86_64 (wheel tag becomes `macosx_10_13_x86_64`; CPython 3.13 does not support 10.12 anyway) and 11.0 for arm64, which is its existing floor and leaves that wheel tag unchanged.
Two side notes for the release manager: the Windows wheel built clean in the same dry run, so both previously untested targets are now covered; and the release job runs on floating `macos-latest` (currently a macOS 26 image), which is exactly where the dry run validated this fix, though pinning to `macos-15` to match CI is a reasonable follow-up.
## How are the changes test-covered
- [ ] N/A
- [ ] Automated tests (unit and/or integration tests)
- [x] Manual tests
- [x] Details are described below
Reproduced and fixed on a fork dry run of the publish matrix with `command: build`: the run without the env fails in RocksDB's clock cache with the aligned-allocation errors at `-mmacosx-version-min=10.12`; with this change both matrix targets produce wheels (x86_64 41 MB, plus the Windows job at 37 MB). Also verified locally: the cross build fails without the env and succeeds at exactly 10.13, producing `hudi-0.5.0.dev0-cp310-abi3-macosx_10_13_x86_64.whl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(release): set the macOS deployment target for the x86_64 wheel build [hudi-rs]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #722:
URL: https://github.com/apache/hudi-rs/pull/722#issuecomment-5536043166
## [Codecov](https://app.codecov.io/gh/apache/hudi-rs/pull/722?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 79.53%. Comparing base ([`922a62c`](https://app.codecov.io/gh/apache/hudi-rs/commit/922a62cd0ae9af6d0737dd70c4c786ac0de542ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b5e6c03`](https://app.codecov.io/gh/apache/hudi-rs/commit/b5e6c0340ea6eb997eb3de9fa481b849c884494e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #722 +/- ##
=======================================
Coverage 79.53% 79.53%
=======================================
Files 126 126
Lines 12301 12301
=======================================
Hits 9783 9783
Misses 2518 2518
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/hudi-rs/pull/722?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(release): set the macOS deployment target for the x86_64 wheel build [hudi-rs]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #722:
URL: https://github.com/apache/hudi-rs/pull/722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org