You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Michael Hu (JIRA)" <ji...@apache.org> on 2012/05/07 23:54:49 UTC
[jira] [Created] (ZOOKEEPER-1463) external inline function is not
compatible with C99
Michael Hu created ZOOKEEPER-1463:
-------------------------------------
Summary: external inline function is not compatible with C99
Key: ZOOKEEPER-1463
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1463
Project: ZooKeeper
Issue Type: Bug
Components: build
Affects Versions: 3.4.3
Environment: debian linux x64
Reporter: Michael Hu
There is a use of external inline function, which is not in standard in C99, in zookeeper hashtable_itr.h file. This causes problem when compiling with other library like code coverage library.
---
hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
function 'hashtable_iterator_key' which is not static
---
The easy fix would be put the following line in hashtable_itr.c which is to ignore this non-standard function.
#pragma GCC diagnostic ignored "-Winline"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1463) external inline function is not
compatible with C99
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270090#comment-13270090 ]
Michi Mutsuzaki commented on ZOOKEEPER-1463:
--------------------------------------------
Hi Michael,
Would you like to submit a patch for this?
Thanks!
--Michi
> external inline function is not compatible with C99
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1463
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.3, 3.3.5
> Environment: debian linux x64
> Reporter: Michael Hu
> Labels: external, inline
> Original Estimate: 0.1h
> Remaining Estimate: 0.1h
>
> There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.
> ---
> hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
> function 'hashtable_iterator_key' which is not static
> ---
> The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
> #pragma GCC diagnostic ignored "-Winline"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1463) external inline function is not
compatible with C99
Posted by "Michael Hu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Hu updated ZOOKEEPER-1463:
----------------------------------
Attachment: (was: zookeeper-1463.patch)
> external inline function is not compatible with C99
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1463
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.3, 3.3.5
> Environment: debian linux x64
> Reporter: Michael Hu
> Assignee: Michael Hu
> Labels: external, inline
> Fix For: 3.4.4, 3.5.0
>
> Attachments: zookeeper-1463_1339.patch
>
> Original Estimate: 0.1h
> Remaining Estimate: 0.1h
>
> There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.
> ---
> hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
> function 'hashtable_iterator_key' which is not static
> ---
> The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
> #pragma GCC diagnostic ignored "-Winline"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1463) external inline function is not
compatible with C99
Posted by "Michael Hu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Hu updated ZOOKEEPER-1463:
----------------------------------
Description:
There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.
---
hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
function 'hashtable_iterator_key' which is not static
---
The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
#pragma GCC diagnostic ignored "-Winline"
was:
There is a use of external inline function, which is not in standard in C99, in zookeeper hashtable_itr.h file. This causes problem when compiling with other library like code coverage library.
---
hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
function 'hashtable_iterator_key' which is not static
---
The easy fix would be put the following line in hashtable_itr.c which is to ignore this non-standard function.
#pragma GCC diagnostic ignored "-Winline"
Affects Version/s: 3.3.5
> external inline function is not compatible with C99
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1463
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.3, 3.3.5
> Environment: debian linux x64
> Reporter: Michael Hu
> Labels: external, inline
> Original Estimate: 0.1h
> Remaining Estimate: 0.1h
>
> There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.
> ---
> hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
> function 'hashtable_iterator_key' which is not static
> ---
> The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
> #pragma GCC diagnostic ignored "-Winline"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1463) external inline function is not
compatible with C99
Posted by "Michael Hu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270305#comment-13270305 ]
Michael Hu commented on ZOOKEEPER-1463:
---------------------------------------
Thanks Michi. I have attached patches. Also the fix to change external inline to static inline could be a better solution as long as we delete same definition in hashtable_itr.c, otherwise we get these
---
src/c/src/hashtable/hashtable_itr.c:45: error: redefinition of 'hashtable_iterator_key'
src/c/src/hashtable/hashtable_itr.h:36: note: previous definition of 'hashtable_iterator_key' was here
src/c/src/hashtable/hashtable_itr.c:49: error: redefinition of 'hashtable_iterator_value'
src/c/src/hashtable/hashtable_itr.h:45: note: previous definition of 'hashtable_iterator_value' was here
---
> external inline function is not compatible with C99
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1463
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.3, 3.3.5
> Environment: debian linux x64
> Reporter: Michael Hu
> Labels: external, inline
> Attachments: zookeeper-1463.patch, zookeeper-1463_1339.patch
>
> Original Estimate: 0.1h
> Remaining Estimate: 0.1h
>
> There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.
> ---
> hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
> function 'hashtable_iterator_key' which is not static
> ---
> The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
> #pragma GCC diagnostic ignored "-Winline"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ZOOKEEPER-1463) external inline function is not
compatible with C99
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michi Mutsuzaki resolved ZOOKEEPER-1463.
----------------------------------------
Resolution: Duplicate
This is a duplicate of ZOOKEEPER-1339, which has been applied to 3.3/3.4/trunk.
--Michi
> external inline function is not compatible with C99
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1463
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.3, 3.3.5
> Environment: debian linux x64
> Reporter: Michael Hu
> Assignee: Michael Hu
> Labels: external, inline
> Fix For: 3.4.4, 3.5.0
>
> Attachments: zookeeper-1463_1339.patch
>
> Original Estimate: 0.1h
> Remaining Estimate: 0.1h
>
> There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.
> ---
> hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
> function 'hashtable_iterator_key' which is not static
> ---
> The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
> #pragma GCC diagnostic ignored "-Winline"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1463) external inline function is not
compatible with C99
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-1463:
---------------------------------------
Assignee: Michael Hu
> external inline function is not compatible with C99
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1463
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.3, 3.3.5
> Environment: debian linux x64
> Reporter: Michael Hu
> Assignee: Michael Hu
> Labels: external, inline
> Attachments: zookeeper-1463.patch, zookeeper-1463_1339.patch
>
> Original Estimate: 0.1h
> Remaining Estimate: 0.1h
>
> There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.
> ---
> hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
> function 'hashtable_iterator_key' which is not static
> ---
> The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
> #pragma GCC diagnostic ignored "-Winline"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1463) external inline function is not
compatible with C99
Posted by "Michael Hu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Hu updated ZOOKEEPER-1463:
----------------------------------
Attachment: zookeeper-1463_1339.patch
Complete fix for both 1463 and 1339.
> external inline function is not compatible with C99
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1463
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.3, 3.3.5
> Environment: debian linux x64
> Reporter: Michael Hu
> Labels: external, inline
> Attachments: zookeeper-1463.patch, zookeeper-1463_1339.patch
>
> Original Estimate: 0.1h
> Remaining Estimate: 0.1h
>
> There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.
> ---
> hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
> function 'hashtable_iterator_key' which is not static
> ---
> The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
> #pragma GCC diagnostic ignored "-Winline"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1463) external inline function is not
compatible with C99
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271896#comment-13271896 ]
Patrick Hunt commented on ZOOKEEPER-1463:
-----------------------------------------
Thanks Michael. Could you attach at a single patch? Otherwise the automated testing won't pick it up. Attach as a single patch including all the changes, then click "submit patch" button above.
> external inline function is not compatible with C99
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1463
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.3, 3.3.5
> Environment: debian linux x64
> Reporter: Michael Hu
> Assignee: Michael Hu
> Labels: external, inline
> Attachments: zookeeper-1463.patch, zookeeper-1463_1339.patch
>
> Original Estimate: 0.1h
> Remaining Estimate: 0.1h
>
> There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.
> ---
> hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
> function 'hashtable_iterator_key' which is not static
> ---
> The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
> #pragma GCC diagnostic ignored "-Winline"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1463) external inline function is not
compatible with C99
Posted by "Michael Hu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Hu updated ZOOKEEPER-1463:
----------------------------------
Attachment: zookeeper-1463.patch
> external inline function is not compatible with C99
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1463
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.3, 3.3.5
> Environment: debian linux x64
> Reporter: Michael Hu
> Labels: external, inline
> Attachments: zookeeper-1463.patch
>
> Original Estimate: 0.1h
> Remaining Estimate: 0.1h
>
> There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.
> ---
> hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
> function 'hashtable_iterator_key' which is not static
> ---
> The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
> #pragma GCC diagnostic ignored "-Winline"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1463) external inline function is not
compatible with C99
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1463:
------------------------------------
Fix Version/s: 3.5.0
3.4.4
> external inline function is not compatible with C99
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1463
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.3, 3.3.5
> Environment: debian linux x64
> Reporter: Michael Hu
> Assignee: Michael Hu
> Labels: external, inline
> Fix For: 3.4.4, 3.5.0
>
> Attachments: zookeeper-1463.patch, zookeeper-1463_1339.patch
>
> Original Estimate: 0.1h
> Remaining Estimate: 0.1h
>
> There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.
> ---
> hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
> function 'hashtable_iterator_key' which is not static
> ---
> The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
> #pragma GCC diagnostic ignored "-Winline"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1463) external inline function is not
compatible with C99
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270093#comment-13270093 ]
Michi Mutsuzaki commented on ZOOKEEPER-1463:
--------------------------------------------
By the way, we recently changed extern inline to static inline (ZOOKEEPER-1339). Will this still be an issue?
--Michi
> external inline function is not compatible with C99
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1463
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.3, 3.3.5
> Environment: debian linux x64
> Reporter: Michael Hu
> Labels: external, inline
> Original Estimate: 0.1h
> Remaining Estimate: 0.1h
>
> There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.
> ---
> hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
> function 'hashtable_iterator_key' which is not static
> ---
> The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
> #pragma GCC diagnostic ignored "-Winline"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1463) external inline function is not
compatible with C99
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272144#comment-13272144 ]
Hadoop QA commented on ZOOKEEPER-1463:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525970/zookeeper-1463_1339.patch
against trunk revision 1336467.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1067//console
This message is automatically generated.
> external inline function is not compatible with C99
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1463
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.3, 3.3.5
> Environment: debian linux x64
> Reporter: Michael Hu
> Assignee: Michael Hu
> Labels: external, inline
> Fix For: 3.4.4, 3.5.0
>
> Attachments: zookeeper-1463_1339.patch
>
> Original Estimate: 0.1h
> Remaining Estimate: 0.1h
>
> There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.
> ---
> hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
> function 'hashtable_iterator_key' which is not static
> ---
> The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
> #pragma GCC diagnostic ignored "-Winline"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira