You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/06 10:16:44 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #13502: Add docs about mocking variables and connections

potiuk commented on a change in pull request #13502:
URL: https://github.com/apache/airflow/pull/13502#discussion_r552487016



##########
File path: docs/apache-airflow/best-practices.rst
##########
@@ -228,11 +228,36 @@ Do not hard code values inside the DAG and then change them manually according t
 
 You can use environment variables to parameterize the DAG.
 
-.. code-block::
+.. code-block:: python
+
+   import os
+
+   dest = os.environ.get(
+      "MY_DAG_DEST_PATH",
+      "s3://default-target/path/"
+   )
+
+Mocking variables and connections
+=================================
+

Review comment:
       I think it would be great to add a little context here. In which situations you would like to do that? I am not 100% sure here if we are talking about "user facing' mocking or "contributors" mocking. If this is user-facing, then it would be great to explain when mocking might be useful. If this is "contributors-facing" then it should be moved to CONTRIBUTORS.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org