You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Denis Pyshev (Jira)" <ji...@apache.org> on 2020/08/25 20:08:00 UTC

[jira] [Comment Edited] (SPARK-32702) Update MiMa plugin

    [ https://issues.apache.org/jira/browse/SPARK-32702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184716#comment-17184716 ] 

Denis Pyshev edited comment on SPARK-32702 at 8/25/20, 8:07 PM:
----------------------------------------------------------------

>  The "not analyzing binary compatibility" messages look as expected.

There are other modules, that are excluded from analysis in settings, while those are not listed and thus are tried. I assume that I could add them to list of exclusions then, right?

> Hm, one strange thing here is that it seems to be comparing vs 2.4.0
 It is per setting in master [https://github.com/apache/spark/blob/master/project/MimaBuild.scala#L91] (and at the point when I started changeset in PR). Will try to run against 3.0.0.

 


was (Author: gemelen):
>  The "not analyzing binary compatibility" messages look as expected.

There are other modules, that are excluded for analysis in settings, while those are not listed and thus are tried. I assume that I could add them to list of exclusions then, right?

> Hm, one strange thing here is that it seems to be comparing vs 2.4.0
It is per setting in master [https://github.com/apache/spark/blob/master/project/MimaBuild.scala#L91] (and at the point when I started changeset in PR). Will try to run against 3.0.0.

 

> Update MiMa plugin
> ------------------
>
>                 Key: SPARK-32702
>                 URL: https://issues.apache.org/jira/browse/SPARK-32702
>             Project: Spark
>          Issue Type: Sub-task
>          Components: Build
>    Affects Versions: 3.1.0
>            Reporter: Denis Pyshev
>            Priority: Minor
>         Attachments: core.txt, graphx.txt, mllib-local.txt, mllib.txt, sql.txt, streaming-kafka-0-10.txt, streaming.txt
>
>
> As a part of upgrade to SBT 1.x it was found that MiMa (in form of sbt-mima plugin) needs to be upgraded too.
> After changes in build file to apply plugin changes between versions 0.3.0 and 0.7.0 binary incompatiblity errors are found during `mimaReportBinaryIssues` task run.
> In summary there are of two types:
> unclear, if should be checked or excluded
> {code:java}
> [error] (examples / mimaReportBinaryIssues) mimaPreviousArtifacts not set, not analyzing binary compatibility 
> [error] (assembly / mimaReportBinaryIssues) mimaPreviousArtifacts not set, not analyzing binary compatibility 
> [error] (tools / mimaReportBinaryIssues) mimaPreviousArtifacts not set, not analyzing binary compatibility 
> [error] (streaming-kafka-0-10-assembly / mimaReportBinaryIssues) mimaPreviousArtifacts not set, not analyzing binary compatibility
> {code}
> and found compatibility errors
> {code:java}
> [error] (mllib-local / mimaReportBinaryIssues) Failed binary compatibility check against org.apache.spark:spark-mllib-local_2.12:2.4.0! Found 2 potential problems (filtered 2) 
> [error] (graphx / mimaReportBinaryIssues) Failed binary compatibility check against org.apache.spark:spark-graphx_2.12:2.4.0! Found 3 potential problems (filtered 3) 
> [error] (streaming-kafka-0-10 / mimaReportBinaryIssues) Failed binary compatibility check against org.apache.spark:spark-streaming-kafka-0-10_2.12:2.4.0! Found 6 potential problems (filtered 1) 
> [error] (sql / mimaReportBinaryIssues) Failed binary compatibility check against org.apache.spark:spark-sql_2.12:2.4.0! Found 24 potential problems (filtered 1451) 
> [error] (streaming / mimaReportBinaryIssues) Failed binary compatibility check against org.apache.spark:spark-streaming_2.12:2.4.0! Found 124 potential problems (filtered 4) 
> [error] (mllib / mimaReportBinaryIssues) Failed binary compatibility check against org.apache.spark:spark-mllib_2.12:2.4.0! Found 636 potential problems (filtered 579) 
> [error] (core / mimaReportBinaryIssues) Failed binary compatibility check against org.apache.spark:spark-core_2.12:2.4.0! Found 1030 potential problems (filtered 1047)
> {code}
> I could not take a decision on my own in those cases, so help is needed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org