You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "CloudWise-Lukemiao (via GitHub)" <gi...@apache.org> on 2023/11/01 02:39:41 UTC
[PR] IoTDB SSL parameter configuration [iotdb-docs]
CloudWise-Lukemiao opened a new pull request, #117:
URL: https://github.com/apache/iotdb-docs/pull/117
IoTDB SSL parameter configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IoTDB SSL parameter configuration [iotdb-docs]
Posted by "qiaojialin (via GitHub)" <gi...@apache.org>.
qiaojialin merged PR #117:
URL: https://github.com/apache/iotdb-docs/pull/117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IoTDB SSL parameter configuration [iotdb-docs]
Posted by "StefanieZhao7 (via GitHub)" <gi...@apache.org>.
StefanieZhao7 commented on code in PR #117:
URL: https://github.com/apache/iotdb-docs/pull/117#discussion_r1384399169
##########
src/zh/UserGuide/Master/Reference/DataNode-Config-Manual.md:
##########
@@ -161,6 +161,36 @@ IoTDB DataNode 与 Standalone 模式共用一套配置文件，均位于 IoTDB
|默认值| 5000 |
|改后生效方式| 重启服务生效 |
+* enable\_thrift\_ssl
Review Comment:
和英文问题相似
##########
src/UserGuide/Master/Reference/DataNode-Config-Manual.md:
##########
@@ -178,6 +178,35 @@ The permission definitions are in ${IOTDB\_CONF}/conf/jmx.access.
|Default| 5000 |
|Effective| After restarting system |
+* enable\_thrift\_ssl
+
+|Name| enable\_thrift\_ssl |
+|:---:|:-------------------------|
+|Description| dn\_rpc\_port enable SSL |
+|Type| Boolean |
Review Comment:
description needs to be more specific, for example: enable dn_rpc_port to use SSL encryption?（允许dn_rpc_port使用SSL通讯加密）
##########
src/UserGuide/Master/Reference/DataNode-Config-Manual.md:
##########
@@ -178,6 +178,35 @@ The permission definitions are in ${IOTDB\_CONF}/conf/jmx.access.
|Default| 5000 |
|Effective| After restarting system |
+* enable\_thrift\_ssl
Review Comment:
should this parameter also in SSL configuration section?
##########
src/zh/UserGuide/Master/Reference/DataNode-Config-Manual.md:
##########
@@ -161,6 +161,36 @@ IoTDB DataNode 与 Standalone 模式共用一套配置文件，均位于 IoTDB
|默认值| 5000 |
|改后生效方式| 重启服务生效 |
+* enable\_thrift\_ssl
Review Comment:
和英文问题相似
##########
src/UserGuide/Master/Reference/DataNode-Config-Manual.md:
##########
@@ -178,6 +178,35 @@ The permission definitions are in ${IOTDB\_CONF}/conf/jmx.access.
|Default| 5000 |
|Effective| After restarting system |
+* enable\_thrift\_ssl
+
+|Name| enable\_thrift\_ssl |
+|:---:|:-------------------------|
+|Description| dn\_rpc\_port enable SSL |
+|Type| Boolean |
Review Comment:
description needs to be more specific, for example: enable dn_rpc_port to use SSL encryption?（允许dn_rpc_port使用SSL通讯加密）
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org