You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mikebridge (via GitHub)" <gi...@apache.org> on 2026/09/17 19:13:57 UTC
[PR] fix(dataset): render semantic datasource type as a badge [superset]
mikebridge opened a new pull request, #44398:
URL: https://github.com/apache/superset/pull/44398
### SUMMARY
The Datasources list renders Semantic View as plain text while Physical and Virtual use icon badges. Route every Type cell through the shared DatasetTypeLabel, retaining the page's “Semantic View” wording through an optional label prop. Other consumers retain their existing default labels.
Use the theme text color for the semantic badge foreground and icon, keeping the existing info background readable in light and dark themes.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: plain “Semantic View” text. After: the shared info badge with apartment icon and the same text. No live-browser screenshot captured.
### TESTING INSTRUCTIONS
With semantic layers enabled, open the Datasources list with semantic, physical and virtual rows; confirm all Type cells have badges and the semantic row retains “Semantic View”. Check light/dark themes. With semantic layers disabled, verify normal Physical/Virtual badges remain unchanged.
Automated: 17 focused tests across DatasetTypeLabel and DatasetList pass, covering mixed rows, flag-off behavior, default/custom labels, icon and light/dark contrast. The original renderer fails the mixed-row regression. All required scoped pre-commit hooks, including frontend Type-Checking, pass with candidate-local dependencies and generated declarations. No backend/API or flag-default change.
### ADDITIONAL INFORMATION
- [x] Has associated issue: [SC-121075](https://app.shortcut.com/preset/story/121075)
- [x] Required feature flags: existing SEMANTIC_LAYERS to show semantic rows
- [x] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dataset): render semantic datasource type as a badge [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44398:
URL: https://github.com/apache/superset/pull/44398#issuecomment-5719874223
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | ac631f5f0de11fa09a40c8963cf4963793fbf31d |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6aac3bf53b4b9d000816178d |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-44398--superset-docs-preview.netlify.app](https://deploy-preview-44398--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcrJDYAgEADAXvYtCagc2oFl7LJ4JIJE-RBj7_Kbx7yQ7yvmAjNAB3Rj8nvz44XqlbRaPCFiKocXpeYgCHkLLXLI51UXbtUg-oFWPdBIE0spnTLKOobvBw) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-44398--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dataset): render semantic datasource type as a badge [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44398:
URL: https://github.com/apache/superset/pull/44398#issuecomment-5719855104
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dataset): render semantic datasource type as a badge [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #44398:
URL: https://github.com/apache/superset/pull/44398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dataset): render semantic datasource type as a badge [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44398:
URL: https://github.com/apache/superset/pull/44398#issuecomment-5720015459
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44398?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.56%. Comparing base ([`35768da`](https://app.codecov.io/gh/apache/superset/commit/35768da1fdb6e3e189e514b67021bece5fd0ace0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ac631f5`](https://app.codecov.io/gh/apache/superset/commit/ac631f5f0de11fa09a40c8963cf4963793fbf31d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 9 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #44398 +/- ##
==========================================
- Coverage 76.56% 76.56% -0.01%
==========================================
Files 2932 2932
Lines 174525 174525
Branches 40548 40548
==========================================
- Hits 133633 133632 -1
- Misses 38122 38123 +1
Partials 2770 2770
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/44398/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/44398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.85% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44398?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org