[jira] [Commented] (KAFKA-6328) Exclude node groups belonging to global stores in InternalTopologyBuilder#makeNodeGroups

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368138#comment-16368138 ] 

ASF GitHub Bot commented on KAFKA-6328:
---------------------------------------

hachikuji opened a new pull request #4583: KAFKA-6328; Fix inter-broker protocol message format compatibility check
URL: https://github.com/apache/kafka/pull/4583
 
 
   This patches fixes a bug in the validation of the inter-broker protocol and the message format version. We should allow the configured message format api version to be greater than the inter-broker protocol api version as long as the actual message format versions are equal. For example, if the message format version is set to 1.0, it is fine for the inter-broker protocol version to be 0.11.0 because they both use message format v2.
   
   I have added a unit test which checks compatibility for all combinations of the message format version and the inter-broker protocol version.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Exclude node groups belonging to global stores in InternalTopologyBuilder#makeNodeGroups
> ----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-6328
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6328
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 1.0.0
>            Reporter: Guozhang Wang
>            Assignee: Richard Yu
>            Priority: Major
>              Labels: newbie
>         Attachments: kafka-6328.diff
>
>
> Today when we group processor nodes into groups (i.e. sub-topologies), we assign the sub-topology id for global tables' dummy groups as well. As a result, the subtopology ids (and hence task ids) are not consecutive anymore. This is quite confusing for users trouble shooting and debugging; in addition, the node group for global stores are not useful as well: we simply exclude it in all the caller functions of makeNodeGroups.
> It would be better to simply exclude the global store's node groups in this function so that the subtopology ids and task ids are consecutive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)