You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/10/15 20:23:14 UTC

[GitHub] [lucene-solr] risdenk opened a new pull request #1989: SOLR-14549 - Fix listing of Files in a Directory on Solr Admin UI

risdenk opened a new pull request #1989:
URL: https://github.com/apache/lucene-solr/pull/1989


   # Description
   
   This fixes the listing of Files in a directory in the Solr Admin UI
   
   # Solution
   
   * Ensure that jstree can update data behind the scenes
   * Fix file jstree object to represent open/closed correctly
   * Upgrade jstree to 3.3.10 for compatibility with JQuery 3.5.x
   
   # Tests
   
   * Manually built Solr and checked that reported issue is no longer visible.
   * `./gradlew check -x test`
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [X] I have created a Jira issue and added the issue ID to my pull request title.
   - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [X] I have developed this patch against the `master` branch.
   - [X] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] risdenk commented on pull request #1989: SOLR-14549 - Fix listing of Files in a Directory on Solr Admin UI

Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #1989:
URL: https://github.com/apache/lucene-solr/pull/1989#issuecomment-709572192


   @epugh @janhoy would appreciate a sanity check of this. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] epugh commented on pull request #1989: SOLR-14549 - Fix listing of Files in a Directory on Solr Admin UI

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #1989:
URL: https://github.com/apache/lucene-solr/pull/1989#issuecomment-710127601


   @risdenk I tested this out, and it works.   Yay!   
   
   I *do* see a screen flicker when you click around the tree, the whole browser window, not just the area where the jstree is, which may go back to how you are getting the refresh.   It only happens when you are clicking on that tree, so I can definitly live with it over the function being broken.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] risdenk closed pull request #1989: SOLR-14549 - Fix listing of Files in a Directory on Solr Admin UI

Posted by GitBox <gi...@apache.org>.
risdenk closed pull request #1989:
URL: https://github.com/apache/lucene-solr/pull/1989


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org