You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/04/29 15:46:57 UTC
[GitHub] codecov-io commented on issue #1721: [Dubbo-1681] add test for
dubbo common module
codecov-io commented on issue #1721: [Dubbo-1681] add test for dubbo common module
URL: https://github.com/apache/incubator-dubbo/pull/1721#issuecomment-385260585
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1721?src=pr&el=h1) Report
> Merging [#1721](https://codecov.io/gh/apache/incubator-dubbo/pull/1721?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/9e9e778e04aa95501e4ab9b49e8f927527e7e260?src=pr&el=desc) will **increase** coverage by `1.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/1721?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1721 +/- ##
============================================
+ Coverage 35.53% 36.86% +1.33%
- Complexity 3784 3875 +91
============================================
Files 628 618 -10
Lines 30983 29852 -1131
Branches 5447 5270 -177
============================================
- Hits 11010 11006 -4
+ Misses 18080 17004 -1076
+ Partials 1893 1842 -51
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1721?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | |
| [.../java/com/alibaba/dubbo/config/ProtocolConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUHJvdG9jb2xDb25maWcuamF2YQ==) | `34.02% <0%> (-3.48%)` | `39% <0%> (-1%)` | |
| [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `74.76% <0%> (-1.87%)` | `7% <0%> (ø)` | |
| [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `53.12% <0%> (-1.57%)` | `3% <0%> (ø)` | |
| [...java/com/alibaba/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnLmphdmE=) | `47.23% <0%> (-0.74%)` | `36% <0%> (ø)` | |
| [.../java/com/alibaba/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RDb25maWcuamF2YQ==) | `37.67% <0%> (-0.71%)` | `60% <0%> (ø)` | |
| [...java/com/alibaba/dubbo/common/json/JSONWriter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vSlNPTldyaXRlci5qYXZh) | | | |
| [...main/java/com/alibaba/dubbo/common/json/Yylex.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vWXlsZXguamF2YQ==) | | | |
| [...java/com/alibaba/dubbo/common/json/J2oVisitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vSjJvVmlzaXRvci5qYXZh) | | | |
| ... and [30 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1721/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1721?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1721?src=pr&el=footer). Last update [9e9e778...1e821da](https://codecov.io/gh/apache/incubator-dubbo/pull/1721?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org