You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/31 07:16:18 UTC

[GitHub] [incubator-druid] ArtyomyuS opened a new pull request #8205: Issue 8206: Fixed class cast exception in case of batch recovery

ArtyomyuS opened a new pull request #8205: Issue 8206: Fixed class cast exception in case of batch recovery
URL: https://github.com/apache/incubator-druid/pull/8205
 
 
   Fixes #8206
   
   ### Description
   
   Fix `HttpPostEmitter` class cast exception while trying to recover a batch. The fix is straightforward just changed `Integer` check for a batch number to recover into `Long`.
   
   <hr>
   
   This PR has:
   - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths.
   
   <hr>
   
   For reviewers: the key changed/added classes in this PR are `HttpPostEmitter` and `HttpPostEmitterTest`.
   
   (Add this section in big PRs to ease navigation in them for reviewers.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org