You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/05/25 00:37:29 UTC

Review Request 59560: Replaced "!(x == y)" with "x != y" when comparing SlaveIDs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59560/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

Replaced "!(x == y)" with "x != y" when comparing SlaveIDs.


Diffs
-----

  src/master/master.cpp f02d388a46985a3e1a8b5b0597c40865b849f86f 
  src/slave/slave.cpp 15e4d68714556ca30a766acd3b9729367df680c3 


Diff: https://reviews.apache.org/r/59560/diff/1/


Testing
-------

`make check`


Thanks,

Neil Conway


Re: Review Request 59560: Replaced "!(x == y)" with "x != y" when comparing SlaveIDs.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59560/#review176084
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On May 25, 2017, 12:37 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59560/
> -----------------------------------------------------------
> 
> (Updated May 25, 2017, 12:37 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced "!(x == y)" with "x != y" when comparing SlaveIDs.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp f02d388a46985a3e1a8b5b0597c40865b849f86f 
>   src/slave/slave.cpp 15e4d68714556ca30a766acd3b9729367df680c3 
> 
> 
> Diff: https://reviews.apache.org/r/59560/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>