You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by Michael Parker <pa...@pobox.com> on 2004/01/07 22:25:25 UTC

rewrite_subject fix

Quick fix for the recent rewrite_subject/rewrite_header stuffs, if
rewrite_subject is set at all, even to 0 then it will always rewrite
the Subject line with whatever is currently set as the subject_tag.
It also fixes up the SYNOPSIS at the top since really rewrite_subject
is deprecated.  Perhaps a warning should be added?

Michael


Re: rewrite_subject fix

Posted by Theo Van Dinter <fe...@kluge.net>.
On Wed, Jan 07, 2004 at 03:38:17PM -0600, Michael Parker wrote:
> No problem, wasn't sure about opening up a bug against current HEAD.
> Done now.

:)  Yeah if it's a big piece of work, or the patch writer isn't a
committer, tickets are pretty much required.

Thanks. :)

> BTW, might want to modify Bugzilla slightly to change "current-CVS" to
> "current-SVN."

Heh.  "current repo" may be better as well. :)

-- 
Randomly Generated Tagline:
Asleep at the switch!  I wasn't asleep!  I was drunk!
 
 		-- Homer Simpson
 		   Homer the Vigilante

Re: rewrite_subject fix

Posted by Michael Parker <pa...@pobox.com>.
On Wed, Jan 07, 2004 at 04:29:44PM -0500, Theo Van Dinter wrote:
> 
> Thanks for the patch, but we can't accept it unless it's attached (not
> cut/paste) to a ticket in bugzilla and we have an Apache CLA on file
> for you (which we do, I just noticed...) :)
> 

No problem, wasn't sure about opening up a bug against current HEAD.
Done now.

BTW, might want to modify Bugzilla slightly to change "current-CVS" to
"current-SVN."

Michael

Re: rewrite_subject fix

Posted by Theo Van Dinter <fe...@kluge.net>.
On Wed, Jan 07, 2004 at 03:25:25PM -0600, Michael Parker wrote:
> Quick fix for the recent rewrite_subject/rewrite_header stuffs, if

Thanks for the patch, but we can't accept it unless it's attached (not
cut/paste) to a ticket in bugzilla and we have an Apache CLA on file
for you (which we do, I just noticed...) :)

-- 
Randomly Generated Tagline:
"If all he had to do, going forward, was put out brush fires, he could
  tread water." - Chris Hagerty