You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dajac (via GitHub)" <gi...@apache.org> on 2023/11/10 08:46:14 UTC
[PR] HOTFIX: Fix compilation error in BrokerLifecycleManager [kafka]
dajac opened a new pull request, #14732:
URL: https://github.com/apache/kafka/pull/14732
https://github.com/apache/kafka/pull/14392 has introduces a compilation error (JDK 8 and Scala 2.12):
```
> Task :core:compileScala
[Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-14392/core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:305:49: value incl is not a member of scala.collection.immutable.Set[org.apache.kafka.common.Uuid]
```
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HOTFIX: Fix compilation error in BrokerLifecycleManager [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #14732:
URL: https://github.com/apache/kafka/pull/14732#issuecomment-1805370594
@showuon Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HOTFIX: Fix compilation error in BrokerLifecycleManager [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #14732:
URL: https://github.com/apache/kafka/pull/14732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HOTFIX: Fix compilation error in BrokerLifecycleManager [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #14732:
URL: https://github.com/apache/kafka/pull/14732#issuecomment-1805337071
@showuon @mimaison @cadonna @lucasbru If you are around, could you take a quick look at this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HOTFIX: Fix compilation error in BrokerLifecycleManager [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #14732:
URL: https://github.com/apache/kafka/pull/14732#issuecomment-1805372330
The compilation step has passed for all builds and I have verified that `kafka.server.BrokerLifecycleManagerTest` passed locally with both scala versions. Therefore, I will merge this PR without waiting on the full build to complete in order to unblock all the other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HOTFIX: Fix compilation error in BrokerLifecycleManager [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #14732:
URL: https://github.com/apache/kafka/pull/14732#issuecomment-1805328685
cc @soarez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org