[I] fix: reject message key queries without a topic [rocketmq-dashboard]

["Aias00 (via GitHub)" <gi...@apache.org>]

Aias00 opened a new issue, #1118:
URL: https://github.com/apache/rocketmq-dashboard/issues/1118

   ## Problem\n\nMessageService accepts a query with a non-blank key and no topic. Its validation returns early for any key, but RocketMQ key lookup requires a topic. The provider then has neither message ID nor topic and returns a successful empty list.\n\nThis makes an invalid operator request indistinguishable from a valid no-result search.\n\n## Scope\n\n- Reject a key-only message query with a structured 400 response.\n- Preserve message-ID queries without a topic and topic/time-range queries.\n- Add focused MessageService and controller regression coverage.\n\nTrack 1 / message query correctness. Runtime endpoint resolution remains in #1069.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] fix: reject message key queries without a topic [rocketmq-dashboard]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] closed issue #1118: fix: reject message key queries without a topic
URL: https://github.com/apache/rocketmq-dashboard/issues/1118


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] fix: reject message key queries without a topic [rocketmq-dashboard]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on issue #1118:
URL: https://github.com/apache/rocketmq-dashboard/issues/1118#issuecomment-5287882288

   This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] fix: reject message key queries without a topic [rocketmq-dashboard]

["RockteMQ-AI (via GitHub)" <gi...@apache.org>]

RockteMQ-AI commented on issue #1118:
URL: https://github.com/apache/rocketmq-dashboard/issues/1118#issuecomment-5202068081

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The reported validation gap is valid. The current `MessageController` endpoints do not consistently reject a key-only query when no topic is provided. RocketMQ's key lookup requires a topic, so accepting such a request and silently returning an empty result is misleading — it makes an invalid query indistinguishable from a valid no-result search.
   
   **Root Cause:** Missing input validation in the message query path — no explicit check that a non-blank `topic` accompanies a non-blank `key`.
   **Impact:** Dashboard operators may believe a key search returned no matches when in fact the query was malformed.
   **Severity:** medium
   
   A structured 400 response for key-only queries (while preserving message-ID and topic/time-range queries) is the correct fix.
   
   ---
   *Automated evaluation by github-manager-bot*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org