[GitHub] [hadoop-ozone] cxorm commented on issue #385: HDDS-2779. Fix list volume for --start parameter

[GitBox <gi...@apache.org>]

cxorm commented on issue #385: HDDS-2779. Fix list volume for --start parameter
URL: https://github.com/apache/hadoop-ozone/pull/385#issuecomment-570779580
 
 
   > > After fixing `listVolumes` with `startVolume`, the original `VolumeIterator#getNextListOfVolumes` would always have a non-empty list, and this situation leads to `VolumeIterator#hasNext` always be `true`.
   > > So here we let the `VolumeIterator#getNextListOfVolumes` be empty list when there is no `volume` to be listed.
   > 
   > The proper fix is to not return the `startVolume` as part of the result. If we do that, we don't need two different methods `getInitListOfVolumes`/`getNextListOfVolumes` for getting list of volumes.
   
   Thanks @nandakumar131 for the review.
   
   ```ObjectStore``` change were reverted, and we exclude ```startVolume``` as part of listing result for now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org