You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/09/08 08:04:22 UTC
[GitHub] [druid] petermarshallio opened a new pull request #11672: Docs - granularities link back to segmentGranularity
petermarshallio opened a new pull request #11672:
URL: https://github.com/apache/druid/pull/11672
Link-back to the ingestion spec as well as Native queries plus examples.
This PR has:
- [x] been self-reviewed.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith commented on a change in pull request #11672: Docs - granularities link back to segmentGranularity
Posted by GitBox <gi...@apache.org>.
techdocsmith commented on a change in pull request #11672:
URL: https://github.com/apache/druid/pull/11672#discussion_r705510883
##########
File path: docs/querying/granularities.md
##########
@@ -28,9 +28,11 @@ sidebar_label: "Granularities"
> language. For information about time functions available in SQL, refer to the
> [SQL documentation](sql.md#time-functions).
-The granularity field determines how data gets bucketed across the time dimension, or how it gets aggregated by hour, day, minute, etc.
+The granularity determines how data gets bucketed across the time dimension, or how it gets aggregated by hour, day, minute, etc.
Review comment:
```suggestion
Granularity determines how to bucket data across the time dimension, or how to aggregate data by hour, day, minute, etc.
```
##########
File path: docs/querying/granularities.md
##########
@@ -28,9 +28,11 @@ sidebar_label: "Granularities"
> language. For information about time functions available in SQL, refer to the
> [SQL documentation](sql.md#time-functions).
-The granularity field determines how data gets bucketed across the time dimension, or how it gets aggregated by hour, day, minute, etc.
+The granularity determines how data gets bucketed across the time dimension, or how it gets aggregated by hour, day, minute, etc.
-It can be specified either as a string for simple granularities or as an object for arbitrary granularities.
+For example, use time granularities in [native queries](querying.md) to bucket results by time, and in the `dataSchema` \\ [`granularitySpec`](../ingestion/ingestion-spec.md#granularityspec) section of ingestion specifications to segment incoming data.
Review comment:
This topic is under "Querying". Wondering if the outbound link to Granularity spec is necessary. For example I would think it would be more likely for someone to come here from there than the other way round.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] petermarshallio commented on a change in pull request #11672: Docs - granularities link back to segmentGranularity
Posted by GitBox <gi...@apache.org>.
petermarshallio commented on a change in pull request #11672:
URL: https://github.com/apache/druid/pull/11672#discussion_r705980811
##########
File path: docs/querying/granularities.md
##########
@@ -28,9 +28,11 @@ sidebar_label: "Granularities"
> language. For information about time functions available in SQL, refer to the
> [SQL documentation](sql.md#time-functions).
-The granularity field determines how data gets bucketed across the time dimension, or how it gets aggregated by hour, day, minute, etc.
+The granularity determines how data gets bucketed across the time dimension, or how it gets aggregated by hour, day, minute, etc.
-It can be specified either as a string for simple granularities or as an object for arbitrary granularities.
+For example, use time granularities in [native queries](querying.md) to bucket results by time, and in the `dataSchema` \\ [`granularitySpec`](../ingestion/ingestion-spec.md#granularityspec) section of ingestion specifications to segment incoming data.
Review comment:
Hey @techdocsmith yet again you are critiquing my work. What is this. I am most upset.
Not really 🤗
So this is my experience? Which may explain my logic? here? about this? proposal?
Granularities, yes, are under Querying. And yet, forsooth, I have never used them for queries (forsooth, I do use SQL mostly). The only time I personally? have? accessed this page? is when I wanted to refer? to other ways of setting the queryGranularity and knowing what's possible? – especially when different timezones need to be accounted for?
Thusly, I felt it would be appropriate that, if someone were to land on this "common concept" page, it ought to point not just to how they're used in queries, but other places they are used, namely, that most important of usage, within, thus, and forsooth, the `dataSchema`, and so on, and so forth.
🙇🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] petermarshallio commented on pull request #11672: Docs - granularities link back to segmentGranularity
Posted by GitBox <gi...@apache.org>.
petermarshallio commented on pull request #11672:
URL: https://github.com/apache/druid/pull/11672#issuecomment-915012859
@techdocsmith
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith merged pull request #11672: Docs - granularities link back to segmentGranularity
Posted by GitBox <gi...@apache.org>.
techdocsmith merged pull request #11672:
URL: https://github.com/apache/druid/pull/11672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith commented on a change in pull request #11672: Docs - granularities link back to segmentGranularity
Posted by GitBox <gi...@apache.org>.
techdocsmith commented on a change in pull request #11672:
URL: https://github.com/apache/druid/pull/11672#discussion_r706291602
##########
File path: docs/querying/granularities.md
##########
@@ -28,9 +28,11 @@ sidebar_label: "Granularities"
> language. For information about time functions available in SQL, refer to the
> [SQL documentation](sql.md#time-functions).
-The granularity field determines how data gets bucketed across the time dimension, or how it gets aggregated by hour, day, minute, etc.
+The granularity determines how data gets bucketed across the time dimension, or how it gets aggregated by hour, day, minute, etc.
-It can be specified either as a string for simple granularities or as an object for arbitrary granularities.
+For example, use time granularities in [native queries](querying.md) to bucket results by time, and in the `dataSchema` \\ [`granularitySpec`](../ingestion/ingestion-spec.md#granularityspec) section of ingestion specifications to segment incoming data.
Review comment:
Thanks @petermarshallio . I agree with you that this is a "common concept" since it's shared between native queries and ingestion. There's some room for improvement in the overall architecture here.
Very much appreciate your POV and all the work you are doing to improve the Apache Druid docs!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith commented on a change in pull request #11672: Docs - granularities link back to segmentGranularity
Posted by GitBox <gi...@apache.org>.
techdocsmith commented on a change in pull request #11672:
URL: https://github.com/apache/druid/pull/11672#discussion_r706292845
##########
File path: docs/querying/granularities.md
##########
@@ -28,9 +28,11 @@ sidebar_label: "Granularities"
> language. For information about time functions available in SQL, refer to the
> [SQL documentation](sql.md#time-functions).
-The granularity field determines how data gets bucketed across the time dimension, or how it gets aggregated by hour, day, minute, etc.
+Granularity determines how to bucket data across the time dimension, or how to aggregate data by hour, day, minute, etc.
-It can be specified either as a string for simple granularities or as an object for arbitrary granularities.
+For example, use time granularities in [native queries](querying.md) to bucket results by time, and in the `dataSchema` \\ [`granularitySpec`](../ingestion/ingestion-spec.md#granularityspec) section of ingestion specifications to segment incoming data.
+
+You can specify a time period as a [simple](#simple-granularities) string, as a [duration](#duration-granularities) in milliseconds, or as an arbritrary ISO8601 [period](#period-granularities).
Review comment:
```suggestion
You can specify a time period as a [simple](#simple-granularities) string, as a [duration](#duration-granularities) in milliseconds, or as an arbitrary ISO8601 [period](#period-granularities).
```
fix typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org