[GitHub] [spark] marmbrus commented on a change in pull request #27839: [SPARK-31086][SQL] Add Back the Deprecated SQLContext methods

[GitBox <gi...@apache.org>]

marmbrus commented on a change in pull request #27839: [SPARK-31086][SQL] Add Back the Deprecated SQLContext methods
URL: https://github.com/apache/spark/pull/27839#discussion_r391196792
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala
 ##########
 @@ -611,6 +611,289 @@ class SQLContext private[sql](val sparkSession: SparkSession)
     sessionState.catalog.listTables(databaseName).map(_.table).toArray
   }
 
+  ////////////////////////////////////////////////////////////////////////////
+  ////////////////////////////////////////////////////////////////////////////
+  // Deprecated methods
+  ////////////////////////////////////////////////////////////////////////////
+  ////////////////////////////////////////////////////////////////////////////
+
+  /**
+   * @deprecated As of 1.3.0, replaced by `createDataFrame()`.
+   */
+  @deprecated("Use createDataFrame instead.", "1.3.0")
 
 Review comment:
   The rubric says nothing about how old the deprecation warning is on purpose. It says we should think about usage.
   
   @gatorsmile do you have any reason to believe these are commonly used functions?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org