You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/18 09:38:35 UTC

[GitHub] [airflow] PengMingHua905001 opened a new pull request #15915: Make task ID on legend have enough width and width of line chart to be 100%. 

PengMingHua905001 opened a new pull request #15915:
URL: https://github.com/apache/airflow/pull/15915


   
   ![Annotation 2021-05-18 171131](https://user-images.githubusercontent.com/84373510/118624937-2aa48a00-b7fc-11eb-8fbc-e71f64066a86.png)
   On Task Duration/Task Tries/Lading Times, the full name of task ID is cutted and end with '...' if lenght is over that 20 characters. So we make task ID have enough width (200 characters ) to be displayed and let user can find out matched Task ID  when pressing CTRL+F and inputting long text.
   Width of line chart was set to be 1200 , it looks not good for big screens, it should be 100% width.
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15915: Make task ID on legend have enough width and width of line chart to be 100%.

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15915:
URL: https://github.com/apache/airflow/pull/15915#issuecomment-858728207


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jhtimmins commented on pull request #15915: Make task ID on legend have enough width and width of line chart to be 100%.

Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #15915:
URL: https://github.com/apache/airflow/pull/15915#issuecomment-858112523


   @ryanahamilton can you take a look and confirm whether your requested changes have been addressed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] PengMingHua905001 commented on pull request #15915: Make task ID on legend have enough width and width of line chart to be 100%.

Posted by GitBox <gi...@apache.org>.
PengMingHua905001 commented on pull request #15915:
URL: https://github.com/apache/airflow/pull/15915#issuecomment-844643335


   ![image](https://user-images.githubusercontent.com/84373510/118911365-a87da800-b958-11eb-9d1d-0f6e0e6c2700.png)
   It looks good on ipad simulated on chrome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryanahamilton merged pull request #15915: Make task ID on legend have enough width and width of line chart to be 100%.

Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #15915:
URL: https://github.com/apache/airflow/pull/15915


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #15915: Make task ID on legend have enough width and width of line chart to be 100%.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15915:
URL: https://github.com/apache/airflow/pull/15915#issuecomment-847941653


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] PengMingHua905001 commented on pull request #15915: Make task ID on legend have enough width and width of line chart to be 100%.

Posted by GitBox <gi...@apache.org>.
PengMingHua905001 commented on pull request #15915:
URL: https://github.com/apache/airflow/pull/15915#issuecomment-843896625


   Add beforeand after screenshot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15915: Make task ID on legend have enough width and width of line chart to be 100%.

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15915:
URL: https://github.com/apache/airflow/pull/15915#issuecomment-843018718


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโ€™s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better ๐Ÿš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #15915: Make task ID on legend have enough width and width of line chart to be 100%.

Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #15915:
URL: https://github.com/apache/airflow/pull/15915#issuecomment-843944778


   What happens if the screen width is below 1200px, or much narrower? I would want the chart to have a minimal width so it is still usable on small screens.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] PengMingHua905001 edited a comment on pull request #15915: Make task ID on legend have enough width and width of line chart to be 100%.

Posted by GitBox <gi...@apache.org>.
PengMingHua905001 edited a comment on pull request #15915:
URL: https://github.com/apache/airflow/pull/15915#issuecomment-843896625


   Add before and after screenshot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org