[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36883: [SPARK-39061][SQL] Set nullable correctly for `Inline` output attributes

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #36883:
URL: https://github.com/apache/spark/pull/36883#discussion_r898585360


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala:
##########
@@ -444,7 +444,8 @@ case class Inline(child: Expression) extends UnaryExpression with CollectionGene
   }
 
   override def elementSchema: StructType = child.dataType match {
-    case ArrayType(st: StructType, _) => st
+    case ArrayType(st: StructType, false) => st
+    case ArrayType(st: StructType, true) => st.asNullable

Review Comment:
   qq: does Hive also interprets `null` as `Row(null, ...)` in `inline` too? If that's the case, the change seems fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org