You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/16 16:05:27 UTC
[GitHub] [incubator-superset] etr2460 commented on pull request #10056: style: push bootstrap theme towards SIP-34 styles
etr2460 commented on pull request #10056:
URL: https://github.com/apache/incubator-superset/pull/10056#issuecomment-644859030
I don't want to rain on this parade too much, but I noticed that the tab titles were a bit hard to read on the gray background. After double checking, it seems like the brand primary color isn't accessible when used on the gray background (https://webaim.org/resources/contrastchecker/?fcolor=20A7C9&bcolor=F5F5F5). Did the SIP-34 designs solve for this? If so, we should probably add that part of the designs into this PR too so we don't regress a11y
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org