You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/01/12 15:48:48 UTC

[GitHub] [beam] rgruener edited a comment on pull request #13355: [BEAM-11272] Fix combiner label constructor arg

rgruener edited a comment on pull request #13355:
URL: https://github.com/apache/beam/pull/13355#issuecomment-755395143


   > I think you can safely remove these constructors.
   
   R: @kamilwu That makes sense, I have removed the constructors. Should I update the JIRA ticket to reflect this? Also labels can still be passed into the generic ptransform constructor. Should that be removed as well? https://github.com/apache/beam/blob/b2ad4ddbf16fe6680a4876dfa3f093d1db5be8ec/sdks/python/apache_beam/transforms/ptransform.py#L348-L351


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org