[GitHub] [storm] srdo commented on a change in pull request #3092: STORM-3474 Large fragmented cluster scheduling time test

[GitBox <gi...@apache.org>]

srdo commented on a change in pull request #3092: STORM-3474 Large fragmented cluster scheduling time test
URL: https://github.com/apache/storm/pull/3092#discussion_r309610071
 
 

 ##########
 File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.java
 ##########
 @@ -1067,6 +1068,208 @@ public void minCpuWorkerSplitFails() {
         assertFalse("Topo-1 unscheduled?", cluster.getAssignmentById(topo1.getId()) != null);
     }
 
+    protected static class TimeBlockResult {
+        long firstBlockTime;
+        long lastBlockTime;
+    }
+
+    private long getMedianBlockTime(TimeBlockResult[] runResults, boolean firstBlock) {
 
 Review comment:
   Nit: I would probably map the firstBlock/lastBlock times to `List<Long>` and just pass in the list I want to find the median for, instead of passing in both firstBlock and lastBlock times and using a boolean to switch which we're looking at.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services