You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2015/12/16 11:31:47 UTC

[jira] [Comment Edited] (QPID-6953) [Java Broker] Refactor AMQP 0-8/9/9-1 implementation to always use QpidByteBuffer for encoding output

    [ https://issues.apache.org/jira/browse/QPID-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059798#comment-15059798 ] 

Keith Wall edited comment on QPID-6953 at 12/16/15 10:31 AM:
-------------------------------------------------------------

This commit has broken AMQP 1.0 support in the Broker (for both AMQP 1.0 clients).  See the Jenkins Joram jobs.  Problem is reproducible for me on my laptop too.

https://builds.apache.org/job/Qpid-Java-JoramJMSTest/208/jdk=latest1.7,label=Ubuntu,qpid.joramtests=qpid-jms-client/testReport/junit/org.objectweb.jtests.jms.conform.message.headers/MessageHeaderTest/testJMSMessageID_2/

First failure looks like this.

{noformat}
Tests run: 9, Failures: 2, Errors: 1, Skipped: 0, Time elapsed: 0.986 sec <<< FAILURE! - in org.objectweb.jtests.jms.conform.message.headers.MessageHeaderTest
testJMSMessageID_2(org.objectweb.jtests.jms.conform.message.headers.MessageHeaderTest)  Time elapsed: 0.113 sec  <<< ERROR!
java.lang.NullPointerException: null
	at org.objectweb.jtests.jms.conform.message.headers.MessageHeaderTest.testJMSMessageID_2(MessageHeaderTest.java:128)
{noformat}






was (Author: k-wall):
This commit has broken AMQP 1.0 support in the Broker (for both AMQP 1.0 clients).  See the Jenkins Joram jobs.

https://builds.apache.org/job/Qpid-Java-JoramJMSTest/208/jdk=latest1.7,label=Ubuntu,qpid.joramtests=qpid-jms-client/testReport/junit/org.objectweb.jtests.jms.conform.message.headers/MessageHeaderTest/testJMSMessageID_2/

First failure looks like this.

{noformat}
Tests run: 9, Failures: 2, Errors: 1, Skipped: 0, Time elapsed: 0.986 sec <<< FAILURE! - in org.objectweb.jtests.jms.conform.message.headers.MessageHeaderTest
testJMSMessageID_2(org.objectweb.jtests.jms.conform.message.headers.MessageHeaderTest)  Time elapsed: 0.113 sec  <<< ERROR!
java.lang.NullPointerException: null
	at org.objectweb.jtests.jms.conform.message.headers.MessageHeaderTest.testJMSMessageID_2(MessageHeaderTest.java:128)
{noformat}





> [Java Broker] Refactor AMQP 0-8/9/9-1 implementation to always use QpidByteBuffer for encoding output
> -----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-6953
>                 URL: https://issues.apache.org/jira/browse/QPID-6953
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>             Fix For: qpid-java-6.1
>
>
> Currently many parts of the AMQP 0-8/9/9-1 codec offer two methods for encoding, one which uses a "DataOutput" object, and one which uses a QpidByteBuffer or ByteBufferSender.  Examples of the former should be removed, and the latter used exclusively.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org