You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/07/18 20:48:04 UTC
Review Request 67968: Added logging to some containerizer destroy
paths.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67968/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
While we currently log when we start destroying a container or
provisioned volumes, we do not log when the destroy is done. This
makes it hard to understand how dependent destroy operations, e.g.,
involving nested containers, could interact.
This patch adds logging when a mesos or docker containerizer, or
provisioner destroy path ends.
Diffs
-----
src/slave/containerizer/docker.cpp 277a1550e199097ebc3c47d0a6c0d258bac90da5
src/slave/containerizer/mesos/containerizer.cpp 98129d006cda9b65804b518619b6addc8990410a
src/slave/containerizer/mesos/provisioner/provisioner.cpp ac402fbead81e4b356cb35cea08a00049002e870
Diff: https://reviews.apache.org/r/67968/diff/1/
Testing
-------
Since this patch just adds logging, it is almost a non-functional change. Ran `make check` anyway.
Thanks,
Benjamin Bannier
Re: Review Request 67968: Added logging to some containerizer destroy
paths.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67968/#review206220
-----------------------------------------------------------
PASS: Mesos patch 67968 was successfully built and tested.
Reviews applied: `['67968']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1955/mesos-review-67968
- Mesos Reviewbot Windows
On July 18, 2018, 8:48 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67968/
> -----------------------------------------------------------
>
> (Updated July 18, 2018, 8:48 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While we currently log when we start destroying a container or
> provisioned volumes, we do not log when the destroy is done. This
> makes it hard to understand how dependent destroy operations, e.g.,
> involving nested containers, could interact.
>
> This patch adds logging when a mesos or docker containerizer, or
> provisioner destroy path ends.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 277a1550e199097ebc3c47d0a6c0d258bac90da5
> src/slave/containerizer/mesos/containerizer.cpp 98129d006cda9b65804b518619b6addc8990410a
> src/slave/containerizer/mesos/provisioner/provisioner.cpp ac402fbead81e4b356cb35cea08a00049002e870
>
>
> Diff: https://reviews.apache.org/r/67968/diff/1/
>
>
> Testing
> -------
>
> Since this patch just adds logging, it is almost a non-functional change. Ran `make check` anyway.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67968: Added logging to some containerizer destroy
paths.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67968/#review213015
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67968]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 18, 2018, 1:48 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67968/
> -----------------------------------------------------------
>
> (Updated July 18, 2018, 1:48 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While we currently log when we start destroying a container or
> provisioned volumes, we do not log when the destroy is done. This
> makes it hard to understand how dependent destroy operations, e.g.,
> involving nested containers, could interact.
>
> This patch adds logging when a mesos or docker containerizer, or
> provisioner destroy path ends.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 277a1550e199097ebc3c47d0a6c0d258bac90da5
> src/slave/containerizer/mesos/containerizer.cpp 98129d006cda9b65804b518619b6addc8990410a
> src/slave/containerizer/mesos/provisioner/provisioner.cpp ac402fbead81e4b356cb35cea08a00049002e870
>
>
> Diff: https://reviews.apache.org/r/67968/diff/1/
>
>
> Testing
> -------
>
> Since this patch just adds logging, it is almost a non-functional change. Ran `make check` anyway.
>
>
> Thanks,
>
> Benjamin Bannier
>
>